Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [UI][V1.0.0-Beta] Fix task group name can't clear bug #9708

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

devosend
Copy link
Contributor

Purpose of the pull request

close #9707

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@devosend devosend added bug Something isn't working UI ui and front end related labels Apr 24, 2022
@devosend devosend self-assigned this Apr 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9708 (f95851b) into dev (a51b710) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9708   +/-   ##
=========================================
  Coverage     40.00%   40.01%           
- Complexity     4473     4474    +1     
=========================================
  Files           835      835           
  Lines         33550    33550           
  Branches       3710     3710           
=========================================
+ Hits          13423    13425    +2     
+ Misses        18881    18876    -5     
- Partials       1246     1249    +3     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51b710...f95851b. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@songjianet songjianet added this to the 3.0.0-beta milestone Apr 25, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 3faa65e into apache:dev Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Next-UI][V1.0.0-Beta] Can not remove the selected task group
4 participants