Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-BE][MASTER-9729]fix process instance global param not include to task instance when master executing #9730

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

Tianqi-Dotes
Copy link
Member

Purpose of the pull request

close #9729

Brief change log

close #9729

Verify this pull request

have test locally.

@codecov-commenter
Copy link

Codecov Report

Merging #9730 (aa2d2f1) into dev (3e85194) will increase coverage by 0.00%.
The diff coverage is 59.52%.

❗ Current head aa2d2f1 differs from pull request most recent head faf7de5. Consider uploading reports for the commit faf7de5 to get more accurate results

@@            Coverage Diff            @@
##                dev    #9730   +/-   ##
=========================================
  Coverage     40.01%   40.01%           
+ Complexity     4475     4474    -1     
=========================================
  Files           835      835           
  Lines         33550    33579   +29     
  Branches       3710     3715    +5     
=========================================
+ Hits          13426    13438   +12     
- Misses        18876    18886   +10     
- Partials       1248     1255    +7     
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/common/Constants.java 80.95% <ø> (ø)
...e/dolphinscheduler/server/master/MasterServer.java 0.00% <0.00%> (ø)
...er/server/master/runner/FailoverExecuteThread.java 0.00% <0.00%> (ø)
...r/server/master/runner/MasterSchedulerService.java 0.00% <ø> (ø)
...er/server/master/runner/WorkflowExecuteThread.java 8.28% <0.00%> (ø)
...lphinscheduler/service/task/TaskPluginManager.java 0.00% <ø> (ø)
...e/dolphinscheduler/server/worker/WorkerServer.java 0.00% <0.00%> (ø)
...nscheduler/service/process/ProcessServiceImpl.java 30.85% <59.09%> (+0.30%) ⬆️
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.10% <66.66%> (-0.12%) ⬇️
.../dolphinscheduler/common/utils/ParameterUtils.java 72.72% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e85194...faf7de5. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

78.6% 78.6% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit e6dade7 into apache:dev Apr 25, 2022
Tianqi-Dotes added a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-BE][MASTER] The startup global parameter was not working.
3 participants