Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-9776] A task instance that normally queries the serial wait state. #9777

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

WangJPLeo
Copy link
Contributor

Purpose of the pull request

Add the instance ID parameter to the task instance that queries the serial wait state.

Brief change log

close #9776

Verify this pull request

Manually verified the change by testing locally.

@songjianet songjianet added bug Something isn't working backend labels Apr 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9777 (167f186) into dev (84cad13) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev    #9777      +/-   ##
============================================
- Coverage     40.07%   40.05%   -0.02%     
+ Complexity     4484     4480       -4     
============================================
  Files           835      835              
  Lines         33575    33575              
  Branches       3712     3712              
============================================
- Hits          13456    13450       -6     
- Misses        18865    18873       +8     
+ Partials       1254     1252       -2     
Impacted Files Coverage Δ
...nscheduler/service/process/ProcessServiceImpl.java 30.85% <0.00%> (ø)
...er/server/master/runner/WorkflowExecuteThread.java 8.29% <100.00%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84cad13...167f186. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Tianqi-Dotes Tianqi-Dotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caishunfeng caishunfeng merged commit 5c0be8a into apache:dev Apr 26, 2022
SnowMoon-Dev pushed a commit to SnowMoon-Dev/dolphinscheduler that referenced this pull request Apr 27, 2022
…9777)

Co-authored-by: WangJPLeo <wangjipeng@whaleops.com>
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
…9777)

Co-authored-by: WangJPLeo <wangjipeng@whaleops.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-RD] Serial wait state task instance cannot be executed
5 participants