Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Hide the version control button in workflow instance #9825

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

devosend
Copy link
Contributor

Purpose of the pull request

close #9750

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@devosend devosend added bug Something isn't working UI ui and front end related labels Apr 28, 2022
@devosend devosend self-assigned this Apr 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9825 (ac6bdbb) into dev (ab2d535) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9825      +/-   ##
============================================
- Coverage     40.40%   40.39%   -0.01%     
+ Complexity     4525     4523       -2     
============================================
  Files           834      834              
  Lines         33639    33639              
  Branches       3721     3721              
============================================
- Hits          13592    13590       -2     
  Misses        18765    18765              
- Partials       1282     1284       +2     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2d535...ac6bdbb. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@songjianet songjianet added this to the 3.0.0-beta milestone Apr 28, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit bb2d4d1 into apache:dev Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-FE] [UI Next] Workflow instances do not support versioning, hide the version control button
3 participants