Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][docs] Add spark sql docs to task spark #9851

Merged
merged 3 commits into from
May 5, 2022
Merged

[Improve][docs] Add spark sql docs to task spark #9851

merged 3 commits into from
May 5, 2022

Conversation

sq-q
Copy link
Contributor

@sq-q sq-q commented Apr 29, 2022

Purpose of the pull request

Add spark sql instructions

Brief change log

Add information on how to use spark how to execute spark sql program.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@SbloodyS
Copy link
Member

Related pr: #9790

SbloodyS
SbloodyS previously approved these changes Apr 29, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you have time to take a look at this PR? @zhongjiajie

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, I had add some comments as below, and could you please use the English version of the screenshot

docs/docs/zh/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/spark.md Outdated Show resolved Hide resolved
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sq-q, docs LGTM, but please change screenshot from Chinese to English

@sq-q
Copy link
Contributor Author

sq-q commented May 5, 2022

Hi @sq-q, docs LGTM, but please change screenshot from Chinese to English

ok, i'll cut it again

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sq-q

@zhongjiajie zhongjiajie merged commit b1bb69c into apache:dev May 5, 2022
@zhongjiajie zhongjiajie changed the title [Improvement-9772][docs/docs-zh] add spark sql docs for Docs [Improve][docs] Add spark sql docs to task spark May 5, 2022
@sq-q
Copy link
Contributor Author

sq-q commented May 5, 2022

LGTM, thanks @sq-q

Grazie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants