Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-9856]Failed to upload the file but get misleading error message #9861

Merged
merged 2 commits into from
May 4, 2022

Conversation

litiliu
Copy link
Contributor

@litiliu litiliu commented May 2, 2022

Purpose of the pull request

this close #9856

Brief change log

This pr add a resources's full name length validation in createResource method before write record to db.
The max length is limited to 128, as #9020 defined in ddl.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

  • Updated dolphinscheduler-api unit test to verify the change .

@litiliu litiliu changed the title [fix-9856]Failed to upload the file but get misleading error message [Fix-9856]Failed to upload the file but get misleading error message May 2, 2022
@SbloodyS SbloodyS added first time contributor First-time contributor backend labels May 2, 2022
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@davidzollo davidzollo merged commit e41de35 into apache:dev May 4, 2022
@litiliu litiliu deleted the fix-9856 branch May 5, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Api] Failed to upload the file because the full name was too long, but get misleading message
3 participants