Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][UI Next][V1.0.0-Beta] Add hints to the password repeat. #9888

Merged
merged 1 commit into from
May 5, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented May 5, 2022

Purpose of the pull request

This pull request adds hints to the password repeat.

Related Issue

close #9882

@songjianet songjianet added feature new feature UI ui and front end related labels May 5, 2022
@songjianet songjianet added this to the 3.0.0-beta milestone May 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9888 (1605130) into dev (083050a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9888   +/-   ##
=========================================
  Coverage     40.31%   40.32%           
- Complexity     4531     4532    +1     
=========================================
  Files           835      835           
  Lines         33747    33747           
  Branches       3726     3726           
=========================================
+ Hits          13606    13607    +1     
  Misses        18853    18853           
+ Partials       1288     1287    -1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083050a...1605130. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 72e6a6d into apache:dev May 5, 2022
@Amy0104 Amy0104 deleted the feature/9882 branch May 10, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][UI-Next] Add hints when passwords are not same on the password change page.
3 participants