Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix#9923] The alarm instance management interface is always in the loading state #9924

Merged
merged 5 commits into from
May 25, 2022
Merged

[Fix#9923] The alarm instance management interface is always in the loading state #9924

merged 5 commits into from
May 25, 2022

Conversation

SnowMoon-Dev
Copy link
Contributor

@SnowMoon-Dev SnowMoon-Dev commented May 6, 2022 •
edited by zhongjiajie
Loading

Purpose of the pull request

Brief change log

close #9923 also close #10207

Verify this pull request

Manually verified the change by testing locally

@SnowMoon-Dev SnowMoon-Dev changed the title fix alert plugin loading bug [FIX#9923] The alarm instance management interface is always in the loding state May 6, 2022
@SnowMoon-Dev SnowMoon-Dev changed the title [FIX#9923] The alarm instance management interface is always in the loding state [Fix#9923] The alarm instance management interface is always in the loding state May 6, 2022
@labbomb
Copy link
Member

labbomb commented May 7, 2022

@SnowMoon-Dev When a request error has been caught and logged, this operation is useless

@devosend devosend added bug Something isn't working UI ui and front end related labels May 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022 •
edited
Loading

Codecov Report

Merging #9924 (3e2cedf) into dev (8562f6a) will increase coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9924      +/-   ##
============================================
+ Coverage     40.31%   40.95%   +0.64%     
- Complexity     4532     4734     +202     
============================================
  Files           835      854      +19     
  Lines         33750    34565     +815     
  Branches       3727     3819      +92     
============================================
+ Hits          13606    14156     +550     
- Misses        18857    19056     +199     
- Partials       1287     1353      +66
Impacted Files Coverage Δ
...inscheduler/api/controller/ExecutorController.java 28.30% <0.00%> (-11.70%) ⬇️
...er/server/builder/TaskExecutionContextBuilder.java 68.88% <0.00%> (-3.21%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...nscheduler/api/service/impl/TenantServiceImpl.java 72.47% <0.00%> (-2.06%) ⬇️
...uler/plugin/task/api/parameters/SqlParameters.java 62.37% <0.00%> (-1.91%) ⬇️
...g/apache/dolphinscheduler/dao/entity/Resource.java 45.88% <0.00%> (-1.68%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️
...heduler/api/service/impl/ResourcesServiceImpl.java 52.26% <0.00%> (-0.86%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8562f6a...3e2cedf. Read the comment docs.

@SnowMoon-Dev SnowMoon-Dev mentioned this pull request May 23, 2022
Closed
3 tasks
@zhongjiajie
Copy link
Member

@songjianet make sure this issue also close #10207

@SnowMoon-Dev SnowMoon-Dev changed the title [Fix#9923] The alarm instance management interface is always in the loding state [Fix#9923] The alarm instance management interface is always in the loading state May 24, 2022
@zhongjiajie
Copy link
Member

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

@SnowMoon-Dev
Copy link
Contributor Author

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

Hi @SnowMoon-Dev, if you could solve one issue in one single PR, you should not separate them into two or more, unless the issue contain more than one issue

Okay, I know

@zhongjiajie zhongjiajie added this to the 3.0.0-beta-1 milestone May 25, 2022
Amy0104
Amy0104 reviewed May 25, 2022
View reviewed changes
dolphinscheduler-ui/src/views/security/alarm-instance-manage/use-form.ts Outdated
}))
} catch (e) {
state.pluginsLoading = false
}
state.pluginsLoading = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting pluginsLoading to false should be within the try block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，thanks

@SnowMoon-Dev SnowMoon-Dev requested a review from Amy0104 May 25, 2022 09:15
devosend
devosend approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@devosend devosend merged commit c5c68a8 into apache:dev May 25, 2022
zhongjiajie pushed a commit that referenced this pull request May 25, 2022
@SnowMoon-Dev @zhongjiajie
[Fix#9923] The alarm instance management interface is always in the l…
69db18e 
…oading state (#9924)

* fix alert plugin loading bug

* update use-form.ts

* remove unused package

* Update use-form.ts

* Update use-form.ts

(cherry picked from commit c5c68a8)
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
@SnowMoon-Dev
[Fix#9923] The alarm instance management interface is always in the l…
286a2b8 
…oading state (apache#9924)

* fix alert plugin loading bug

* update use-form.ts

* remove unused package

* Update use-form.ts

* Update use-form.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devosend devosend devosend approved these changes

@labbomb labbomb Awaiting requested review from labbomb

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

Assignees

@SnowMoon-Dev SnowMoon-Dev

Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Milestone
3.0.0-beta-1
6 participants
@SnowMoon-Dev @labbomb @codecov-commenter @zhongjiajie @devosend @Amy0104