Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix docs deadlink in readme #9972

Merged
merged 4 commits into from
May 11, 2022

Conversation

songjianet
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet self-assigned this May 10, 2022
labbomb
labbomb previously approved these changes May 10, 2022
Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devosend
devosend previously approved these changes May 10, 2022
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #9972 (73fd210) into dev (4c50bf0) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9972      +/-   ##
============================================
- Coverage     40.68%   40.67%   -0.02%     
+ Complexity     4579     4576       -3     
============================================
  Files           834      834              
  Lines         33832    33832              
  Branches       3745     3745              
============================================
- Hits          13765    13761       -4     
- Misses        18747    18752       +5     
+ Partials       1320     1319       -1     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c50bf0...73fd210. Read the comment docs.

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use related path to use the link?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_zh_CN.md Outdated Show resolved Hide resolved
@zhongjiajie zhongjiajie changed the title [Docs] Fix docs url. [doc] Fix docs deadlink in readme May 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@songjianet songjianet merged commit e51d0fb into apache:dev May 11, 2022
zhongjiajie pushed a commit that referenced this pull request May 11, 2022
* [Docs] Fix docs url.

* Update README.md

* Update README.md

* Update README_zh_CN.md

Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
(cherry picked from commit e51d0fb)
@songjianet songjianet deleted the docs-fix-readme-url branch May 11, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants