disable mem save code in shuffle

apache · Oct 1, 2024 · 074a279 · 074a279
1 parent ea29138
commit 074a279
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/be/src/pipeline/exec/hashjoin_build_sink.cpp b/be/src/pipeline/exec/hashjoin_build_sink.cpp
@@ -123,7 +123,7 @@ Status HashJoinBuildSinkLocalState::close(RuntimeState* state, Status exec_statu
             if (_shared_state->build_block) {
                 // release the memory of unused column in probe stage
                 _shared_state->build_block->clear_column_mem_not_keep(
-                        p._should_keep_column_flags, p._shared_hash_table_context.get() != nullptr);
+                        p._should_keep_column_flags, bool(p._shared_hashtable_controller));
             }
         }
 

diff --git a/be/src/vec/core/block.cpp b/be/src/vec/core/block.cpp
@@ -759,7 +759,9 @@ void Block::clear_column_mem_not_keep(const std::vector<bool>& column_keep_flags
             }
         }
 
-        if (need_keep_first && data[0].column->size() != origin_rows) {
+        if (need_keep_first && data.size() == column_keep_flags.size() &&
+            std::all_of(column_keep_flags.begin(), column_keep_flags.end(),
+                        [](bool v) { return v; })) {
             auto first_column = data[0].column->clone_empty();
             first_column->resize(origin_rows);
             data[0].column = std::move(first_column);