[Vectorized](compile) Fix compile error and warning (#7780)

apache · Jan 17, 2022 · 66b3b1d · 66b3b1d
1 parent c86d691
commit 66b3b1d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/be/src/vec/columns/column.h b/be/src/vec/columns/column.h
@@ -220,6 +220,7 @@ class IColumn : public COW<IColumn> {
      */
     virtual Ptr filter_by_selector(const uint16_t* sel, size_t sel_size, Ptr* ptr = nullptr) {
         LOG(FATAL) << "column not support filter_by_selector";
+        __builtin_unreachable();
     };
 
     /// Permutes elements using specified permutation. Is used in sortings.

diff --git a/be/src/vec/functions/function.h b/be/src/vec/functions/function.h
@@ -404,6 +404,7 @@ class IFunction : public std::enable_shared_from_this<IFunction>,
                                              const ColumnNumbers& /*arguments*/,
                                              size_t /*result*/) const final {
         LOG(FATAL) << "prepare is not implemented for IFunction";
+        __builtin_unreachable();
     }
 
     Status prepare(FunctionContext* context, FunctionContext::FunctionStateScope scope) override {
@@ -412,10 +413,12 @@ class IFunction : public std::enable_shared_from_this<IFunction>,
 
     [[noreturn]] const DataTypes& get_argument_types() const final {
         LOG(FATAL) << "get_argument_types is not implemented for IFunction";
+        __builtin_unreachable();
     }
 
     [[noreturn]] const DataTypePtr& get_return_type() const final {
         LOG(FATAL) << "get_return_type is not implemented for IFunction";
+        __builtin_unreachable();
     }
 
 protected:

diff --git a/be/src/vec/functions/function_grouping.cpp b/be/src/vec/functions/function_grouping.cpp
@@ -15,11 +15,11 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "function_grouping.h"
+#include "vec/functions/function_grouping.h"
 
 namespace doris::vectorized {
 void register_function_grouping(SimpleFunctionFactory& factory) {
     factory.register_function<FunctionGrouping>();
     factory.register_function<FunctionGroupingId>();
 }
-}
+} // namespace doris::vectorized