[Bug] Insert from empty source will begin an infinite transaction

[TangSiyang2001]

Search before asking

• I had searched in the issues and found no similar issues.

Version

master

What's Wrong?

As title.
InsertIntoTableCommand#runInternal

private void runInternal(ConnectContext ctx, StmtExecutor executor) throws Exception {
        AbstractInsertExecutor insertExecutor = initPlan(ctx, executor);
        // if the insert stmt data source is empty, directly return, no need to be executed.
        if (insertExecutor.isEmptyInsert()) {
            return;
        }
        insertExecutor.executeSingleInsert(executor, jobId);
}

Here insert command will not be actually started when empty relation, so callback of txn commit and publish will never be called, resulting in an infinite transaction which will only finish when timeout reached.

InsertIntoTableCommand#initPlan (transaction begins here)

public AbstractInsertExecutor initPlan(ConnectContext ctx, StmtExecutor executor) throws Exception {
        // ...
        try {
           // ...
            insertExecutor.beginTransaction();
            insertExecutor.finalizeSink(planner.getFragments().get(0), sink, physicalSink);
            targetTableIf.readUnlock();
        } catch (Throwable e) {
            targetTableIf.readUnlock();
            // the abortTxn in onFail need to acquire table write lock
            if (insertExecutor != null) {
                insertExecutor.onFail(e);
            }
            throw e;
        }

        executor.setProfileType(ProfileType.LOAD);
        // We exposed @StmtExecutor#cancel as a unified entry point for statement interruption,
        // so we need to set this here
        executor.setCoord(insertExecutor.getCoordinator());
        return insertExecutor;
    }

What You Expected?

Empty source optimization should commit and publish transaction.

How to Reproduce?

Just create an empty table, insert data from itself.

Anything Else?

introduced by #34418

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[TangSiyang2001]

Maybe just do not begin a transaction for empty insert is better.