-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](planner)unnecessary cast will be added on children in InPredicate #11033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/planner
Issues or PRs related to the query planner
label
Jul 20, 2022
@EmmyMiao87 @morningman PTAL |
kpfly
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Jul 20, 2022
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
… in InPredicate (apache#11033) (apache#11036) Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #10881
Problem Summary:
We should use equals function rather than Use equals operator to compare two Type in Analyzer#castAllToCompatibleType.
Checklist(Required)
Further comments