Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](array-type) fix 'show create table' return null #11912

Merged
merged 1 commit into from
Aug 19, 2022
Merged

[fix](array-type) fix 'show create table' return null #11912

merged 1 commit into from
Aug 19, 2022

Conversation

carlvinhust2012
Copy link
Contributor

@carlvinhust2012 carlvinhust2012 commented Aug 19, 2022 •
edited
Loading

Proposed changes

  1. this pr is used to solve the problem caused by [feature](compaction) allow to set disable_auto_compaction for tables #11743 when run 'show create table'.
    Issue Number: close [Bug] run 'show create table array_test;' return null  #11911
    [Roadmap] Support Array Type（Q1） #7570

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@carlvinhust2012 carlvinhust2012 changed the title [fix](array-type) run 'show create table' return null [fix](array-type) fix 'show create table' return null Aug 19, 2022
stalary
stalary previously approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju
Copy link
Contributor

LGTM

yiguolei
yiguolei approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiguolei yiguolei merged commit ffe7af4 into apache:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@stalary stalary stalary left review comments

Assignees
No one assigned
Labels
kind/test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] run 'show create table array_test;' return null
4 participants
@carlvinhust2012 @cambyzju @yiguolei @stalary