-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Load) fix bug that last line of data lost for stream load #13066
Merged
dataroaring
merged 1 commit into
apache:master
from
weizuo93:fix-stream-load-last-line-lost
Oct 7, 2022
Merged
[Fix](Load) fix bug that last line of data lost for stream load #13066
dataroaring
merged 1 commit into
apache:master
from
weizuo93:fix-stream-load-last-line-lost
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add some regression test? |
OK, thanks for your review. I will add some test cases. |
…er is more than one character
weizuo93
force-pushed
the
fix-stream-load-last-line-lost
branch
from
September 30, 2022 07:54
d535b87
to
a220790
Compare
Please improve the documentation, line separators and examples to make it clearer for users to use |
dataroaring
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
…er is more than one character (apache#13066)
weizuo93
added a commit
to weizuo93/incubator-doris
that referenced
this pull request
Oct 26, 2022
…er is more than one character (apache#13066)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #13064
Problem summary
Last line of data lost for stream load when line delimiter is more than one character.
Checklist(Required)