Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Load) fix bug that last line of data lost for stream load #13066

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

weizuo93
Copy link
Contributor

Proposed changes

Issue Number: close #13064

Problem summary

Last line of data lost for stream load when line delimiter is more than one character.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

@stalary
Copy link
Contributor

stalary commented Sep 30, 2022

Can you add some regression test?

@weizuo93
Copy link
Contributor Author

Can you add some regression test?

OK, thanks for your review. I will add some test cases.

@weizuo93 weizuo93 force-pushed the fix-stream-load-last-line-lost branch from d535b87 to a220790 Compare September 30, 2022 07:54
@hf200012
Copy link
Contributor

hf200012 commented Oct 6, 2022

Please improve the documentation, line separators and examples to make it clearer for users to use

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8b03977 into apache:master Oct 7, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
weizuo93 added a commit to weizuo93/incubator-doris that referenced this pull request Oct 26, 2022
@yiguolei yiguolei mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Last line of data lost for stream load
5 participants