[fix](hash)update_hashes_with_value method should handle if input value is null #13332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappenLee
reviewed
Oct 12, 2022
| hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), | ||
| sizeof(T), hashes[i]); | ||
| } | ||
| else { |
There was a problem hiding this comment.
here seems do not need compute again ？ just do nothing is ok ？
starocean999
force-pushed
the
master_hash_fix
branch
from
72790b3 to
f90de3c
Compare
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Oct 22, 2022
| for (int i = 0; i < s; i++) { | ||
| hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), sizeof(T), | ||
| hashes[i]); | ||
| if (null_data) { |
There was a problem hiding this comment.
Would it be better to express the logic as the following to save LOC?
for (int i = 0; i < s; i++) {
if (null_data != nullptr && null_data[i] != 0) continue;
hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const char*>(&data[i]), sizeof(T),
hashes[i]);
}
liaoxin01
pushed a commit
to liaoxin01/doris
that referenced
this pull request
Nov 4, 2022
…apache#13548 apache#13591) (apache#931) * update_hashes_with_value method should handle if input value is null apache#13332, fix tpch q75 https://github.com/apache/doris/pull/13332/files commit 8301839 Author: starocean999 <40539150+starocean999@users.noreply.github.com> Date: Thu Oct 13 14:36:01 2022 +0800 * [Bug](sort) Fix bug in string sorter apache#13548, fix user case https://github.com/apache/doris/pull/13548/files commit a7c221d Author: Gabriel <gabrielleebuaa@gmail.com> Date: Sat Oct 22 21:26:23 2022 +0800 * [Bug](decimal) Fix incorrect result for decimal multiply apache#13591, fix user case https://github.com/apache/doris/pull/13591/files commit 7fe7c01 Author: Gabriel <gabrielleebuaa@gmail.com> Date: Tue Oct 25 12:08:49 2022 +0800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...