Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #1483

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Remove unused code #1483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions be/src/olap/rowset/alpha_rowset_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,23 +100,6 @@ OLAPStatus AlphaRowsetWriter::add_row(const char* row, Schema* schema) {
return OLAP_SUCCESS;
}

OLAPStatus AlphaRowsetWriter::add_row_block(RowBlock* row_block) {
if (_writer_state != WRITER_INITED) {
RETURN_NOT_OK(_init());
}
size_t pos = 0;
row_block->set_pos(pos);
RowCursor row_cursor;
row_cursor.init(*(_rowset_writer_context.tablet_schema));
while (pos < row_block->limit()) {
row_block->get_row(pos, &row_cursor);
add_row(&row_cursor);
row_block->pos_inc();
pos = row_block->pos();
}
return OLAP_SUCCESS;
}

OLAPStatus AlphaRowsetWriter::add_rowset(RowsetSharedPtr rowset) {
_need_column_data_writer = false;
// this api is for LinkedSchemaChange
Expand Down
2 changes: 0 additions & 2 deletions be/src/olap/rowset/alpha_rowset_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ class AlphaRowsetWriter : public RowsetWriter {

OLAPStatus add_row(const char* row, Schema* schema) override;

OLAPStatus add_row_block(RowBlock* row_block) override;

// add rowset by create hard link
OLAPStatus add_rowset(RowsetSharedPtr rowset) override;
OLAPStatus add_rowset_for_linked_schema_change(
Expand Down
2 changes: 0 additions & 2 deletions be/src/olap/rowset/rowset_writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ class RowsetWriter {

virtual OLAPStatus add_row(const char* row, Schema* schema) = 0;

virtual OLAPStatus add_row_block(RowBlock* row_block) = 0;

virtual OLAPStatus add_rowset(RowsetSharedPtr rowset) = 0;
virtual OLAPStatus add_rowset_for_linked_schema_change(
RowsetSharedPtr rowset, const SchemaMapping& schema_mapping) = 0;
Expand Down