Add more logs and metrics to trace the broker load process #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Operator wants to known when the job being scheduled as PENDING and LOADING. And how long it takes to finish these sub states. Also add 2 metrics on BE to monitor the memtable's flush time. `memtable_flush_total` and `memtable_flush_duration_us`
imay
requested changes
Jul 23, 2019
| for (auto const& pair: _node_add_batch_time_map) { | ||
| ss << "{" << pair.first << "=" << pair.second << "}"; | ||
| } | ||
| LOG(INFO) << ss.str(); |
There was a problem hiding this comment.
I think you should VLOG(), and use be.conf to switch it to open.
and you should use if (LOG.level) to enclose string constructor.
There was a problem hiding this comment.
VLOG can not be used online..
I think add one log for one load job is OK.
There was a problem hiding this comment.
You can use pattern to make only this module
chaoyli
approved these changes
Jul 23, 2019
imay
approved these changes
Jul 23, 2019
morningman
added a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jul 23, 2019
The Operator wants to known when the job being scheduled as PENDING and LOADING. And how long it takes to finish these sub states. Also add 2 metrics on BE to monitor the memtable's flush time. `memtable_flush_total` and `memtable_flush_duration_us`
Closed
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Operator wants to known when the job being scheduled as PENDING
and LOADING. And how long it takes to finish these sub states. So I add log
at the beginning of each state.
Add 2 metrics on BE to monitor the memtable's flush time.
memtable_flush_totalandmemtable_flush_duration_usAdd a log when closing OlapTableSink, to record the add_batch() time of each
Backend, cumulative.