Show load statement support offset #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
such as `show load order by createtime desc limit 1,2`
HangyuanLiu
changed the title
imay
reviewed
Jul 23, 2019
| long offset = showStmt.getOffset() == -1L ? 0 : showStmt.getOffset(); | ||
| if (offset >= rows.size()) { | ||
| rows = Lists.newArrayList(); | ||
| } else if(limit != -1L) { |
There was a problem hiding this comment.
Suggested change
| } else if(limit != -1L) { | |
| } else if (limit != -1L) { |
imay
previously approved these changes
Jul 23, 2019
morningman
requested changes
Jul 23, 2019
…to show_load_offset
…ubator-doris into show_load_offset
OK |
imay
approved these changes
Jul 23, 2019
morningman
approved these changes
Jul 24, 2019
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jul 28, 2019
Such as `show load order by createtime desc limit 1,2`
Closed
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
…ache#1531) When resize file cache size and restart, file cache will eliminate some segments for fitting the size. And it will encounter an invalid address access error. The reason is that I cache some reference and the datas are removed when eliminating. Fix that by caching key and offset and checking it is valid before used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add show load statement support offset
such as
show load order by createtime desc limit 1,2#1509