Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cumulative compaction for decoupling storage from compution #1576

Merged
merged 11 commits into from
Aug 13, 2019
Merged

Change cumulative compaction for decoupling storage from compution #1576

merged 11 commits into from
Aug 13, 2019

Conversation

chaoyli
Copy link
Contributor

@chaoyli chaoyli commented Aug 2, 2019

  1. Calculate cumulative point when loading tablet first time.
  2. Simplify pick rowsets logic upon delete predicate.
  3. Saving meta and modify rowsets only once after cumulative compaction.

imay
imay requested changes Aug 4, 2019
View reviewed changes
be/src/olap/base_compaction.h Show resolved Hide resolved
yiguolei
yiguolei reviewed Aug 5, 2019
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
yiguolei
yiguolei reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

yiguolei
yiguolei previously approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imay
imay reviewed Aug 7, 2019
View reviewed changes
be/src/olap/tablet_manager.cpp Show resolved Hide resolved
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/tablet.cpp Show resolved Hide resolved
be/src/olap/storage_engine.cpp Outdated Show resolved Hide resolved
yiguolei
yiguolei reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

yiguolei
yiguolei previously approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imay
imay reviewed Aug 8, 2019
View reviewed changes
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
imay
imay reviewed Aug 11, 2019
View reviewed changes
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/compaction.h Show resolved Hide resolved
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
yiguolei
yiguolei reviewed Aug 13, 2019
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imay
imay reviewed Aug 13, 2019
View reviewed changes
be/src/olap/base_compaction.cpp Outdated Show resolved Hide resolved
be/src/olap/base_compaction.h Outdated Show resolved Hide resolved
xy720 and others added 5 commits August 13, 2019 15:04
@xy720
Merge Help document to documentation (#1586)
86b6e74 
Help document collation (integration of help and documentation documents)
Change cumulative compaction for decoupling storage from compution
dbd5647 
1. Calculate cumulative point when loading tablet first time.
2. Simplify pick rowsets logic upon delete predicate.
3. Saving meta and modify rowsets only once after cumulative compaction.
Change base compaction for decoupling storage from compution
f75f7ef 
1. Simplify pick rowsets logic.
2. Saving meta and modify rowsets only once after base compaction.
Extract Compaction Class from CumulativeCompaction and BaseComapction.
3aca6bb 
1. Add annotation to Compaction Class
2. Fix set cumulative_layer_point bug before cumulative compaction completion.
Fix calculate cumulative point bug
059fd2b
imay
imay approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit dcb7572 into apache:master Aug 13, 2019
luwei16 added a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
@luwei16
[feature](selectdb-cloud) Report an error directly when the cluster i…
357defc 
…s empty (apache#1576)

* Report an error directly when the cluster is empty
* fix regression case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei left review comments

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaoyli @imay @yiguolei @xy720