Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doris On ES][Bug-Fix] Fix errors when es username and passwd is empty #1601

Merged
merged 2 commits into from
Aug 8, 2019

Conversation

wuyunfeng
Copy link
Member

Create external es table, when username and password is empty, EsRestClient#execute Request.Builder throws NullPointerException.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 60d997f into apache:master Aug 8, 2019
@wuyunfeng wuyunfeng deleted the doris_on_es branch September 2, 2019 02:53
@imay imay mentioned this pull request Sep 26, 2019
@wuyunfeng wuyunfeng changed the title Fix errors when es username and passwd is empty [Doris On ES][Bug-Fix] Fix errors when es username and passwd is empty Jul 21, 2020
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants