Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vectorized](analytic) fix analytic node of window function get wrong… #16074

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

Issue Number: close #15951

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/exec/vanalytic_eval_node.h Show resolved Hide resolved
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 18, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.39 seconds
load time: 499 seconds
storage size: 17123330875 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230119110734_clickbench_pr_84097.html

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 19, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 61fccc8 into apache:master Jan 23, 2023
morningman pushed a commit that referenced this pull request Jan 23, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/vectorization dev/1.2.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 基础函数rank()开窗排序结果错误
5 participants