Limit the disk usage to avoid running out of disk capacity #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set high watermark and flood stage of disk used capacity. And forbid some operation is disk usage is too high.
chaoyli
requested changes
Aug 26, 2019
| @@ -1057,4 +1058,35 @@ void DataDir::_remove_check_paths_no_lock(const std::set<std::string>& paths) { | |||
| } | |||
| } | |||
|
|
|||
| Status DataDir::update_capacity() { | |||
| try { | |||
| boost::filesystem::path path_name(_path); | |||
There was a problem hiding this comment.
C++14 not support std::filesystem
There was a problem hiding this comment.
C++14 not support std::filesystem
be/src/olap/compaction.cpp
Outdated
| @@ -186,4 +186,17 @@ OLAPStatus Compaction::check_correctness(const Merger& merger) { | |||
| return OLAP_SUCCESS; | |||
| } | |||
|
|
|||
| OLAPStatus Compaction::check_disk_capacity() { | |||
| int64_t incoming_data_size = 0; | |||
There was a problem hiding this comment.
only in SegmentWriter will be ok. All writers only go through the SegmentWriter.
| @@ -59,14 +59,14 @@ DataDir::DataDir(const std::string& path, int64_t capacity_bytes, | |||
| TabletManager* tablet_manager, TxnManager* txn_manager) | |||
| : _path(path), | |||
| _capacity_bytes(capacity_bytes), | |||
| _available_bytes(0), | |||
| _disk_capacity_bytes(0), | |||
There was a problem hiding this comment.
_capacity_bytes and _disk_capacity_bytes are redundant ?
There was a problem hiding this comment.
No, _capacity_bytes is user specified disk capacity, but it currently not used.
_disk_capacity_bytes is the capacity of the disk
be/src/olap/schema_change.cpp
Outdated
| @@ -1889,10 +1889,16 @@ OLAPStatus SchemaChangeHandler::_convert_historical_rowsets(const SchemaChangePa | |||
| VLOG(10) << "begin to convert a history rowset. version=" | |||
| << rs_reader->version().first << "-" << rs_reader->version().second; | |||
|
|
|||
| // check disk capacity | |||
| int64_t tablet_size = rs_reader->rowset()->index_disk_size() + rs_reader->rowset()->data_disk_size(); | |||
| if (sc_params.new_tablet->data_dir()->reach_capacity_limit(tablet_size)) { | |||
morningman
force-pushed
the
disk_usage_limit
branch
from
1f7acec to
1c14526
Compare
chaoyli
approved these changes
Aug 27, 2019
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set high watermark and flood stage of disk used capacity.
And forbid some operations if disk usage is too high.
ISSUE: #1701