-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bitmap_union agg column support insert into and broker load #1721
Conversation
@kangkaisen |
docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md
Show resolved
Hide resolved
|
} | ||
} else if (expr instanceof FunctionCallExpr) { | ||
final FunctionCallExpr functionExpr = (FunctionCallExpr) expr; | ||
if (!functionExpr.getFnName().getFunction().equalsIgnoreCase(FunctionSet.TO_BITMAP)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think BITMAP_UNION() is OK too.
And you should add in
fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java:452
fe/src/main/java/org/apache/doris/planner/StreamLoadScanNode.java:278
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
@@ -37,6 +50,9 @@ | |||
protected final TupleDescriptor desc; | |||
protected Map<String, PartitionColumnFilter> columnFilters; | |||
protected String sortColumn = null; | |||
protected Map<String, SlotDescriptor> slotDescByName = Maps.newHashMap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to unify BrokerScanNode and StreamScanNode, I think you'd better to make another class which is subclass of ScanNode. Because not all ScanNode has these properties, they only are used in loading.
There are a lot change related to load process in my pull request #1695 . |
ca402cc
to
8ac58ef
Compare
OK. I has minimized the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For #1610, make bitmap_union support insert into select and broker load
1 Add a check for select * with bitmap_union
2 Define the bitmap_union column type to varchar(0), because the bitmap real length is variable, when insert into, the bitmap real length maybe larger than origin varchar length.
Test the following case:
1
2
3