Commit kafka offset in routine load #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
requested changes
Sep 3, 2019
|
|
||
| for (auto& kv : ctx->kafka_info->cmt_offset) { | ||
| RdKafka::TopicPartition* tp1 = RdKafka::TopicPartition::create( | ||
| ctx->kafka_info->topic, kv.first, kv.second); |
There was a problem hiding this comment.
Do we need to delete this tp1 after commit?
| switch (ctx->load_src_type) { | ||
| case TLoadSourceType::KAFKA: { | ||
| std::shared_ptr<DataConsumer> consumer; | ||
| HANDLE_ERROR(_data_consumer_pool.get_consumer(ctx, &consumer), "failed to get consumers"); |
There was a problem hiding this comment.
It's better not return any error if we failed to do something after txn is committed.
imay
reviewed
Sep 4, 2019
| @@ -133,6 +133,8 @@ class KafkaDataConsumer : public DataConsumer { | |||
| // reassign partition topics | |||
| virtual Status reset() override; | |||
| virtual bool match(StreamLoadContext* ctx) override; | |||
| // commit kafka offset | |||
| Status commit(std::vector<RdKafka::TopicPartition*> offset); | |||
There was a problem hiding this comment.
Suggested change
| Status commit(std::vector<RdKafka::TopicPartition*> offset); | |
| Status commit(const std::vector<RdKafka::TopicPartition*>& offset); |
There was a problem hiding this comment.
librdkafka api is " ErrorCode commitSync (std::vector<TopicPartition*> &offsets)" , so here can't be const
HangyuanLiu
force-pushed
the
routine_load_commit_kafka_offset
branch
from
a9cd126 to
cba0073
Compare
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…mysql jdbc connector (apache#1734)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit kafka offset in routine load
Kafka will decide whether to delete data based on whether all consumer group is commit offset or not.
If there is no commit offset, the kafka server disk may be full