Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize some kinds of load jobs #1762

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Sep 8, 2019

  1. Support specifying label to Insert Into stmt.
    INSERT INTO tbl1 WITH LABEL label1 ...;

  2. Return job' state corresponding to the existing label in result of stream load.
    ...
    "Status": "Label Already Exists",
    "ExistingJobStatus": "FINISHED"
    ...

  3. Return the recent 2000 transactions in SHOW PROC '/transactions'

#1763

1. Support specifying label to Insert Into stmt.

    INSERT INTO tbl1 WITH LABEL label1 ...;

2. Return job' state corresponding to the existing label in result of stream load.

    ...
    "Status": "Label Already Exists",
    "ExistingJobStatus": "FINISHED"
    ...

3. Return the recent 2000 transactions in SHOW PROC '/transactions'
@@ -81,6 +81,7 @@
public static final String SHUFFLE_HINT = "SHUFFLE";
public static final String NOSHUFFLE_HINT = "NOSHUFFLE";
public static final String STREAMING = "STREAMING";
public static final String IMSERT_LABEL = "LABEL:";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 044489b into apache:master Sep 9, 2019
@imay imay mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants