Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) forbid inline view but not the subquery resolve from parent tuples #18032

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

morrySnow
Copy link
Contributor

in PR #17813 , we want to forbid bind slot on brother's column howerver the fix is not in correct way.
the correct way to do that is forbid inline view but not the subquery resolve from parent tuples.

This reverts commit b91a3b5.

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

in PR apache#17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Mar 22, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow changed the title [fix](planner) forbid subquery register itself in parent's analyzer [fix](planner) forbid inline view but not the subquery resolve from parent tuples Mar 22, 2023
@morningman morningman added usercase Important user case type label dev/1.2.3 labels Mar 23, 2023
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.88 seconds
stream load tsv: 454 seconds loaded 74807831229 Bytes, about 157 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230323014321_clickbench_pr_119063.html

@morrySnow morrySnow merged commit 20d2639 into apache:master Mar 23, 2023
@morrySnow morrySnow deleted the fix_subquery branch March 23, 2023 08:17
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Mar 27, 2023
morningman pushed a commit that referenced this pull request Mar 28, 2023
…arent tuples (#18032)

in PR #17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
morningman pushed a commit that referenced this pull request Mar 30, 2023
luwei16 pushed a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
…from parent tuples (apache#18032)"

in PR apache#17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…arent tuples (apache#18032)

in PR apache#17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…arent tuples (apache#18032)

in PR apache#17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
…from parent tuples (apache#18032)"

in PR apache#17813 , we want to forbid bind slot on brother's column
howerver the fix is not in correct way.
the correct way to do that is forbid subquery register itself in parent's analyzer.

This reverts commit b91a3b5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.2.4-merged kind/test reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants