Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-fix]: Remove conjuncts for empty set node #1840

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

EmmyMiao87
Copy link
Contributor

The function named assign conjuncts has been invoked before creating aggregation plan node.
If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend.
It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node.
For example: select sum(pv) from test where type != 1 and 1=0 group by type;

This commit fix this bug. It remove conjuncts for empty set node.

@imay imay added the kind/fix Categorizes issue or PR as related to a bug. label Sep 21, 2019
@imay
Copy link
Contributor

imay commented Sep 21, 2019

@EmmyMiao87
Can you create a bug labeled Issue, and relate this fix with it?

imay
imay previously approved these changes Sep 21, 2019
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 closed this Sep 23, 2019
@EmmyMiao87 EmmyMiao87 reopened this Sep 23, 2019
@EmmyMiao87 EmmyMiao87 closed this Sep 23, 2019
@EmmyMiao87 EmmyMiao87 reopened this Sep 23, 2019
The function named assign conjuncts has been invoked before creating aggregation plan node.
If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend.
It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node.
For example: select sum(pv) from test where type != 1 and 1=0 group by type;

This commit fix this bug. It remove conjuncts for empty set node.
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 4c7b52d into apache:master Sep 23, 2019
@EmmyMiao87
Copy link
Contributor Author

#1847 #1847

@imay imay mentioned this pull request Sep 26, 2019
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Oct 9, 2019
The function named assign conjuncts has been invoked before creating aggregation plan node.
If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend.
It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node.
For example: select sum(pv) from test where type != 1 and 1=0 group by type;

This commit fix this bug. It remove conjuncts for empty set node.
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants