-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug-fix]: Remove conjuncts for empty set node #1840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@EmmyMiao87 |
imay
previously approved these changes
Sep 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The function named assign conjuncts has been invoked before creating aggregation plan node. If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend. It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node. For example: select sum(pv) from test where type != 1 and 1=0 group by type; This commit fix this bug. It remove conjuncts for empty set node.
EmmyMiao87
force-pushed
the
emptysetnode_bug
branch
from
September 23, 2019 04:33
5087da5
to
0562ce0
Compare
imay
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Oct 9, 2019
The function named assign conjuncts has been invoked before creating aggregation plan node. If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend. It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node. For example: select sum(pv) from test where type != 1 and 1=0 group by type; This commit fix this bug. It remove conjuncts for empty set node.
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function named assign conjuncts has been invoked before creating aggregation plan node.
If the empty set node is the child of aggregation node, the conjuncts will be assign to empty set node which could not be executed correctly in Backend.
It will thrown the exception "couldn't resolve slot descriptor" for query which has both empty set node and aggregation node.
For example: select sum(pv) from test where type != 1 and 1=0 group by type;
This commit fix this bug. It remove conjuncts for empty set node.