Bug-fix: Enable StringLiteral cast to Varchar #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
previously approved these changes
Sep 23, 2019
For issue: apache#1842 StringLiteral could be cast to VARCHAR or CHAR. The default value of lead and lag function could be 'String' when the column type is CHAR or VARCHAR.
EmmyMiao87
force-pushed
the
stringliteral_cast_bug
branch
from
9991852 to
6b68a25
Compare
Closed
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
After selectdb/selectdb-core#1697, `DeltaWriter::init` will be called in bthread stack, and `DeltaWriter::init` may call `Tablet::prepare_compaction_and_calculate_permits` when there are too many rowsets in tablet, must not use thread local based `Trace` in bthread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #1842
StringLiteral could be cast to VARCHAR or CHAR.
The default value of lead and lag function could be 'String' when the column type is CHAR or VARCHAR.