Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] enhance show data types stmt #18831

Merged
merged 15 commits into from
May 9, 2023
Merged

[Improvement] enhance show data types stmt #18831

merged 15 commits into from
May 9, 2023

Conversation

ZashJie
Copy link
Contributor

@ZashJie ZashJie commented Apr 19, 2023 •
edited
Loading

enhance show data types stmt
mysql> show data types;
+----------------+------+
| TypeName | Size |
+----------------+------+
| ARRAY | 32 |
| BIGINT | 8 |
| BITMAP | 16 |
| BOOLEAN | 1 |
| CHAR | 16 |
| DATE | 16 |
| DATETIME | 16 |
| DATETIMEV2 | 8 |
| DATEV2 | 4 |
| DECIMAL128 | 16 |
| DECIMAL32 | 4 |
| DECIMAL64 | 8 |
| DECIMALV2 | 16 |
| DOUBLE | 8 |
| FLOAT | 4 |
| HLL | 16 |
| INT | 4 |
| JSONB | 16 |
| LARGEINT | 16 |
| MAP | 24 |
| QUANTILE_STATE | 16 |
| SMALLINT | 2 |
| STRING | 16 |
| TINYINT | 1 |
| VARCHAR | 16 |
+----------------+------+
25 rows in set (0.01 sec)

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Apr 19, 2023
dataroaring
dataroaring requested changes Apr 23, 2023
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowDataTypesStmt.java Outdated
List<String> row = new ArrayList<>();
if (type.isAvailableInDdl()) {
if (type.isDecimalV2Type()) {
row.add("DECIMAL");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not handle type name here, should be handled in PrimitiveType too.

dataroaring
dataroaring previously approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 26, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.9 seconds
stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230508190356_clickbench_pr_140459.html

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 27, 2023

run buildall

2 similar comments
@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 27, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 27, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 28, 2023
@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run buildall

1 similar comment
@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run p1

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run buildp0

1 similar comment
@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 28, 2023

run buildp1

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp1

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp0p1

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp1

1 similar comment
@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp1

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented Apr 29, 2023

run buildp1

@ZashJie
Copy link
Contributor Author

ZashJie commented May 5, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented May 6, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 6, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented May 6, 2023

run buildp0

@dataroaring
Copy link
Contributor

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run p0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run buildall

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run p0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run buildp0

6 similar comments
@ZashJie
Copy link
Contributor Author

ZashJie commented May 7, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

1 similar comment
@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildp0

@ZashJie
Copy link
Contributor Author

ZashJie commented May 8, 2023

run buildall

dataroaring
dataroaring approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 9, 2023
@dataroaring dataroaring merged commit 4302cea into apache:master May 9, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
@ZashJie @Reminiscent
[Improvement](data types) enhance show data types stmt (apache#18831)
8603c18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZashJie @dataroaring @hello-stephen