add spark-doris-connector extension #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Nov 18, 2019
wuyunfeng
requested changes
Nov 18, 2019
wuyunfeng
reviewed
Nov 20, 2019
wuyunfeng
reviewed
Nov 20, 2019
There was a problem hiding this comment.
This is a great Job！ I left some minor comments. Thanks @vinson0526
...nsion/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java
Outdated
Show resolved
Hide resolved
wuyunfeng
reviewed
Nov 20, 2019
wuyunfeng
reviewed
Nov 20, 2019
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java
Show resolved
Hide resolved
...ion/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
wuyunfeng
reviewed
Nov 21, 2019
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java
Outdated
Show resolved
Hide resolved
...ion/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
Outdated
Show resolved
Hide resolved
...ion/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
Outdated
Show resolved
Hide resolved
...ion/spark-doris-connector/src/main/java/org/apache/doris/spark/cfg/ConfigurationOptions.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Outdated
Show resolved
Hide resolved
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
Show resolved
Hide resolved
wuyunfeng
reviewed
Nov 21, 2019
| open(); | ||
| } | ||
| TException ex = null; | ||
| for (int attempt = 0; attempt < retries; ++attempt) { |
There was a problem hiding this comment.
Maybe getNext does not need to retry? Can you explain this?
There was a problem hiding this comment.
maybe failed because of network error.
| logger.debug("CloseScanner to '{}', parameter is '{}'.", routing, closeParams); | ||
| if (!isConnected) { | ||
| try { | ||
| open(); |
There was a problem hiding this comment.
Can you explain why the open() be invoked here?
There was a problem hiding this comment.
in case of 'close' be called outside, you never know how user use it
| return; | ||
| } | ||
| } | ||
| for (int attempt = 0; attempt < retries; ++attempt) { |
There was a problem hiding this comment.
Maybe close() does not need be invoked many times weather fail or not. @imay WDYT？Doris would process any expired context
There was a problem hiding this comment.
retry is try to resolve network error mainly
| private[spark] class DorisPartition(rddId: Int, idx: Int, val dorisPartition: PartitionDefinition) | ||
| extends Partition { | ||
|
|
||
| override def hashCode(): Int = 41 * (41 * (41 + rddId) + idx) + dorisPartition.hashCode() |
There was a problem hiding this comment.
Suggested change
| override def hashCode(): Int = 41 * (41 * (41 + rddId) + idx) + dorisPartition.hashCode() | |
| override def hashCode(): Int = 31 * (31 * (31 + rddId) + idx) + dorisPartition.hashCode() |
...nsion/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala
Show resolved
Hide resolved
...nsion/spark-doris-connector/src/main/scala/org/apache/doris/spark/rdd/ScalaValueReader.scala
Outdated
Show resolved
Hide resolved
|
Thanks @vinson0526 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark-Doris-Connector for Spark to query data from Doris.
More info in: #1525