Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Convert VARCHAR to INT #2481

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Support Convert VARCHAR to INT #2481

merged 1 commit into from
Dec 17, 2019

Conversation

WingsGo
Copy link
Contributor

@WingsGo WingsGo commented Dec 17, 2019

@WingsGo WingsGo changed the title Support Convert Varchar to INT Support Convert VARCHAR to INT Dec 17, 2019
kangkaisen
kangkaisen approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM.

imay
imay approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 89003b7 into apache:master Dec 17, 2019
@WingsGo WingsGo deleted the support_convert_varchar_to_int branch December 17, 2019 14:19
@chaoyli chaoyli mentioned this pull request Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WingsGo @imay @kangkaisen