Add filter conditions for 'show partitions from table' syntax #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
requested changes
Dec 27, 2019
| dbName = ClusterNamespace.getFullName(getClusterName(), dbName); | ||
| } | ||
|
|
||
| analyzeSynTax(analyzer); |
There was a problem hiding this comment.
analyze itself means analyze syntax, so no need to name like analyzeSynTax.
analyzeImpl is better. Like named in other class.
| String leftKey = ((SlotRef) subExpr.getChild(0)).getColumnName(); | ||
| if (subExpr instanceof BinaryPredicate) { | ||
| BinaryPredicate binaryPredicate = (BinaryPredicate) subExpr; | ||
| if (leftKey.equalsIgnoreCase("PartitionName") || leftKey.equalsIgnoreCase("State")) { |
There was a problem hiding this comment.
You can list the filter name at the beginning of the class like:
private static final String FILTER_PARTITION_NAME = "PartitionName";
So it would be more easy to maintain. And same as "State", "LastConsistencyCheckTime", ...
| filterPartitionInfos = Lists.newArrayList(); | ||
| for (List<Comparable> partitionInfo : partitionInfos) { | ||
| if (partitionInfo.size() != TITLE_NAMES.size()) { | ||
| LOG.warn("ParttitionInfos.size() " + partitionInfos.size() |
There was a problem hiding this comment.
I think this is bug and should throw exception?
caiconghui
force-pushed
the
showPartitions
branch
from
f47f404 to
80e8a9c
Compare
infearOnTheWay
pushed a commit
to infearOnTheWay/incubator-doris
that referenced
this pull request
Jan 6, 2020
…#2553) Add filter conditions for show partitions from table syntax, to filter partitions needed
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jan 8, 2020
…#2553) Add filter conditions for show partitions from table syntax, to filter partitions needed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add filter conditions for show partitions from table syntax, to filter partitions needed