Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](load) fix merged row number miscounting because of race condition #26470

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[fix](load) fix merged row number miscounting because of race condition #26470

merged 1 commit into from
Nov 6, 2023

Conversation

freemandealer
Copy link
Contributor

row numbers miscounting because of race condition, will cause load to fail sometimes with warning 'the rows number written doesn't match'.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@freemandealer
[fix](load) fix merged row number miscounting because of race condition
2851ce6 
row numbers miscounting because of race condition, will cause load to
fail sometimes with warning 'the rows number written doesn't match'.

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@freemandealer
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.00% (8391/22677)
Line Coverage: 29.43% (67903/230739)
Region Coverage: 28.11% (35140/125011)
Branch Coverage: 24.90% (17947/72090)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2851ce65dc338c3e7d3f9fd8a806883ac276dfbd_2851ce65dc338c3e7d3f9fd8a806883ac276dfbd/report/index.html

@wm1581066 wm1581066 added dev/2.0.3 usercase Important user case type label labels Nov 6, 2023
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.89 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162103373 Bytes

dataroaring
dataroaring approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring removed the usercase Important user case type label label Nov 6, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

PR approved by anyone and no changes requested.

kaijchen
kaijchen approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bf8793d into apache:master Nov 6, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 8, 2023
@freemandealer @seawinde
[fix](load) fix merged row number miscounting because of race conditi…
96606a0 
…on (apache#26470)

row numbers miscounting because of race condition, will cause load to
fail sometimes with warning 'the rows number written doesn't match'.

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@dataroaring dataroaring mentioned this pull request Nov 12, 2023
Merged
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@freemandealer @seawinde
[fix](load) fix merged row number miscounting because of race conditi…
466f91c 
…on (apache#26470)

row numbers miscounting because of race condition, will cause load to
fail sometimes with warning 'the rows number written doesn't match'.

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@freemandealer
[fix](load) fix merged row number miscounting because of race conditi…
7c83f1d 
…on (apache#26470)

row numbers miscounting because of race condition, will cause load to
fail sometimes with warning 'the rows number written doesn't match'.

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaijchen kaijchen kaijchen approved these changes

@bobhan1 bobhan1 bobhan1 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@freemandealer @doris-robot @kaijchen @bobhan1 @dataroaring @wm1581066