Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix](JDBC Catalog) fix jdbc catalog query bitmap may cause be core sometimes #26933

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[BugFix](JDBC Catalog) fix jdbc catalog query bitmap may cause be core sometimes #26933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions be/src/util/bitmap_value.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,10 +1259,9 @@ class BitmapValue {
}

static std::string empty_bitmap() {
static BitmapValue bitmap;
std::string buf;
buf.resize(bitmap.getSizeInBytes());
bitmap.write_to(buf.data());
std::string buf(sizeof(BitmapValue), 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the original code will core???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BitmapValue::write_to will get a string with size 1 for empty BitmapValue, however the size 1 string will reinterpret to BitmapValue* back in ColumnComplexType::insert:
void insert(const Field& x) override {
const String& s = doris::vectorized::get<const String&>(x);
data.push_back(reinterpret_cast<const T>(s.c_str()));
}

in data.push_back will goto BitmapValue copy constructor, as the _type is not first member in BitmapValue, cause access to an unknown memory location.

BitmapValue* bitmap_value = reinterpret_cast<BitmapValue*>(buf.data());
bitmap_value->_type = EMPTY;
return buf;
}

Expand Down