Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.0](publish version) fix publish version failed but return ok #28425 #28791

Merged

Conversation

yujun777
Copy link
Collaborator

pick: #28424, #28425

BUG: be publish version failed (TxnManager::publish_txn), but the response rpc return status ok. When fe receive the rpc, since its status code is ok, then fe will remove the publish version task. Later fe will no send be retry request. Then BE will not retry publish this txn.

FIX: If TxnManager::publish_txn failed, the reponse rpc should return error.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Collaborator Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yujun777
Copy link
Collaborator Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.78% (7990/21147)
Line Coverage: 29.49% (64917/220150)
Region Coverage: 28.96% (33395/115332)
Branch Coverage: 24.82% (17133/69016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5016babf728477f0a702b82442963c1745fcfc63_5016babf728477f0a702b82442963c1745fcfc63/report/index.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 21, 2023
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.74% (7990/21173)
Line Coverage: 29.45% (64914/220432)
Region Coverage: 28.91% (33385/115472)
Branch Coverage: 24.79% (17127/69094)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4d050d82743b1ee436af74f924398271da4cf98e_4d050d82743b1ee436af74f924398271da4cf98e/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.1 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17162140178 Bytes

@dataroaring dataroaring merged commit f1a9d80 into apache:branch-2.0 Dec 26, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants