Fix failed cases in regression test #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhao7253886
changed the title
imay
requested changes
Nov 12, 2018
| @@ -58,14 +64,14 @@ | |||
| public class FoldConstantsRule implements ExprRewriteRule { | |||
| public static ExprRewriteRule INSTANCE = new FoldConstantsRule(); | |||
|
|
|||
| private Multimap<String, FEFunctionInvoker> functions = ArrayListMultimap.create(); | |||
| private ImmutableMultimap<String, FEFunctionInvoker> functions; | |||
| private ImmutableSet<String> nonNullResultWithNullParamFunctions; | |||
There was a problem hiding this comment.
Need more comment here. I'm not very clear about this attribute's purpose
There was a problem hiding this comment.
ok, i will add some comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analytic functions, Build-in functions with null or error params and Decimal cast fail in regression test.