[dep](thirdparty) import wasmtime library #30591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
TPC-H: Total hot run time: 37158 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172791 ms |
zhangstar333
previously approved these changes
Jan 30, 2024
ClickBench: Total hot run time: 30.15 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 36586 ms |
TPC-DS: Total hot run time: 174150 ms |
ClickBench: Total hot run time: 31.53 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
run buildall |
TPC-H: Total hot run time: 36710 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172575 ms |
ClickBench: Total hot run time: 31.07 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 36609 ms |
TPC-DS: Total hot run time: 175415 ms |
ClickBench: Total hot run time: 30.76 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
I encounter an issue when compiling the latest thirdparty |
|
@taptao FYI, maybe we could rethink the version of these libs because it may not comptable for some machine with old glibc version. some dependency is not avaliable. |
adonis0147
reviewed
Feb 2, 2024
Comment on lines
+598
to
+599
| 'WASMTIME' | ||
| 'WASMTIME_CPP' |
There was a problem hiding this comment.
Hi @taptao , it seems that these libraries don't support macOS (arm64). I think you would better remove these lines here and add them somewhere else after checking the platform. Currently, this script can not be ran successfully on macOS (arm64).
There was a problem hiding this comment.
I noticed this, but my env is mac arm, and the compilation was successful after installing rust, did you get any errors?
There was a problem hiding this comment.
I noticed this, but my env is mac arm, and the compilation was successful after installing rust, did you get any errors?
Hi @taptao , thanks for your prompt reply. I ran the script successfully after setting Rust up.
I installed rust through "curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh" |
yes, this is a big problem, i will rethink about it. any good suggestions? |
HappenLee
added a commit
to HappenLee/incubator-doris
that referenced
this pull request
Feb 4, 2024
This reverts commit 2490d6b.
HappenLee
added a commit
that referenced
this pull request
Feb 4, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Feb 5, 2024
…ache#30795) This reverts commit 2490d6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #24504
Add wasm-lib thirdparty.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...