-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix](Iceberg Catalog) Fix iceberg catalog of hms and hadoop not support iceberg properties #33113
Merged
yiguolei
merged 2 commits into
apache:master
from
GoGoWen:fix_iceberg_hms_and_hadoop_catalog_not_support_iceberg_properties
Apr 5, 2024
Merged
[BugFix](Iceberg Catalog) Fix iceberg catalog of hms and hadoop not support iceberg properties #33113
yiguolei
merged 2 commits into
apache:master
from
GoGoWen:fix_iceberg_hms_and_hadoop_catalog_not_support_iceberg_properties
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39148 ms
|
TPC-DS: Total hot run time: 182591 ms
|
ClickBench: Total hot run time: 30.08 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
morningman
approved these changes
Apr 2, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Apr 2, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Apr 2, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 7, 2024
…upport iceberg properties (#33113) * fix iceberg catalog of hms and hadoop not support iceberg properties * remove unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
when use use iceberg catalog with hms or hadoop type, we can not set the iceberg properties like "io.manifest.cache-enabled" to enable manifest cache in iceberg.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...