Modify partition's version name to what it means #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morningman
commented
Nov 21, 2018
morningman
commented
- committedVersion(Hash) -> visibleVersion(Hash)
- currentVersion(Hash) -> committedVersion(Hash)
- add some comment to make the code more readable.
- fix a ut bug that editlog may be null in CatalogIdGenerator.
1. committedVersion(Hash) -> visibleVersion(Hash) 2. currentVersion(Hash) -> committedVersion(Hash) 3. add some comment to make the code more readable
To avoid unit test failure
yiguolei
reviewed
Nov 21, 2018
| if (allBackends == null || allBackends.size() == 0) { | ||
| LOG.warn("some transaction state need to publish, but no alive backends!!!"); | ||
| if (allBackends.isEmpty()) { | ||
| LOG.warn("some transaction state need to publish, but no backend exists"); | ||
| return; |
There was a problem hiding this comment.
if allbackends == null ,then nptr throws
There was a problem hiding this comment.
allbackends never returns null
yiguolei
reviewed
Nov 21, 2018
yiguolei
reviewed
Nov 21, 2018
| @@ -448,35 +454,40 @@ public void abortTransaction(Long dbId, String label, String reason) throws User | |||
| continue; | |||
| } | |||
| db.readLock(); | |||
| writeLock(); | |||
| try { | |||
There was a problem hiding this comment.
There is no changing here, so read lock is enough.
yiguolei
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.