Optimize the publish logic of streaming load #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morningman
commented
Nov 26, 2018
morningman
commented
- Only collect all error replicas if publish task is timeout.
- Add 2 metrics to monitor the success and failure of txn.
1. Only collect all error replicas if publish task is timeout. 2. Add 2 metrics to monitor the success of failure of txn.
yiguolei
reviewed
Nov 26, 2018
|
|
||
| public boolean isPublishTimeout() { | ||
| // timeout is between 3 to 10 seconds. | ||
| long timeoutMillis = Math.min(Config.publish_version_timeout_second * publishVersionTasks.size() * 1000, 10000); |
There was a problem hiding this comment.
set 10000 to a config, and the minimum value should be 5min
There was a problem hiding this comment.
Set it as Config.load_straggler_wait_second
lide-reed
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.