Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OUTFILE] Support INTO OUTFILE to export query result #3584

Merged
merged 18 commits into from
May 25, 2020
Merged

[OUTFILE] Support INTO OUTFILE to export query result #3584

merged 18 commits into from
May 25, 2020

Conversation

morningman
Copy link
Contributor

@morningman morningman commented May 13, 2020 •
edited
Loading

The proposal can be found here: #3549

This CL mainly changes:

  1. Support SELECT INTO OUTFILE command.
  2. Support export query result to a file via Broker.
  3. Support CSV export format with specified column separator and line delimiter.

The following feature will be implemented in next PR:

  1. Support Parquet export file.

For easy review, please first see the proposal #3549.
Than see the user doc in administrator-guide/outfile.md

@morningman morningman added kind/feature Categorizes issue or PR as related to a new feature. api-review Categorizes an issue or PR as actively needing an API review. area/sql/function Issues or PRs related to the SQL functions labels May 13, 2020
@morningman morningman self-assigned this May 13, 2020
@morningman
Copy link
Contributor Author

This CL is ready for reviewing.
But I have no idea why continuous-integration/travis-ci/pr failed...

yangzhg
yangzhg reviewed May 18, 2020
View reviewed changes
be/src/exec/parquet_writer.cpp Show resolved Hide resolved
be/src/exec/parquet_writer.cpp Show resolved Hide resolved
be/src/runtime/file_result_writer.cpp Show resolved Hide resolved
be/src/runtime/file_result_writer.cpp Outdated Show resolved Hide resolved
be/src/runtime/file_result_writer.cpp Outdated Show resolved Hide resolved
be/src/runtime/mysql_result_writer.h Outdated Show resolved Hide resolved
be/src/runtime/mysql_result_writer.h Show resolved Hide resolved
be/src/runtime/result_sink.cpp Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
docs/zh-CN/administrator-guide/outfile.md Outdated Show resolved Hide resolved
kangkaisen
kangkaisen reviewed May 20, 2020
View reviewed changes
docs/zh-CN/administrator-guide/outfile.md Outdated Show resolved Hide resolved
docs/zh-CN/administrator-guide/outfile.md Outdated Show resolved Hide resolved
docs/zh-CN/administrator-guide/outfile.md Show resolved Hide resolved
be/src/runtime/mysql_result_writer.h Outdated Show resolved Hide resolved
be/src/runtime/mysql_result_writer.h Outdated Show resolved Hide resolved
be/src/runtime/file_result_writer.h Show resolved Hide resolved
be/src/runtime/file_result_writer.h Outdated Show resolved Hide resolved
@morningman
Copy link
Contributor Author

Hi @kangkaisen any more comment?

kangkaisen
kangkaisen previously approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

imay
imay reviewed May 22, 2020
View reviewed changes
docs/zh-CN/administrator-guide/outfile.md Outdated Show resolved Hide resolved
docs/zh-CN/administrator-guide/outfile.md Show resolved Hide resolved
docs/zh-CN/administrator-guide/outfile.md Outdated Show resolved Hide resolved
@morningman
Copy link
Contributor Author

Hi @imay Please review

imay
imay reviewed May 24, 2020
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface LGTM, the implementation details need other's review.

be/src/runtime/query_statistics.h Show resolved Hide resolved
EmmyMiao87
EmmyMiao87 approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 3ffc447 into apache:master May 25, 2020
@EmmyMiao87 EmmyMiao87 mentioned this pull request Aug 17, 2020
Closed
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Nov 12, 2024
@deardeng
(selectdb-cloud) Fix -230 case affected by the default cluster of oth…
ef24c06 
…er cases (apache#3584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangy5 zhangy5 zhangy5 left review comments

@yangzhg yangzhg yangzhg left review comments

@imay imay imay left review comments

@EmmyMiao87 EmmyMiao87 EmmyMiao87 approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees

@morningman morningman

Labels
api-review Categorizes an issue or PR as actively needing an API review. area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@morningman @imay @yangzhg @kangkaisen @zhangy5 @EmmyMiao87 @morningman-cmy