Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support utf-8 encoding in instr, locate, locate_pos, lpad, rpad #3638

Merged
merged 4 commits into from
May 22, 2020
Merged

Support utf-8 encoding in instr, locate, locate_pos, lpad, rpad #3638

merged 4 commits into from
May 22, 2020

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented May 20, 2020 •
edited by morningman
Loading

Support utf-8 encoding for string function instr, locate, locate_pos, lpad, rpad
and add unit test for them

@morningman
Copy link
Contributor

Good work.
Could please add docs for these functions?

@morningman morningman added the area/sql/function Issues or PRs related to the SQL functions label May 20, 2020
kangkaisen
kangkaisen reviewed May 20, 2020
View reviewed changes
be/src/exprs/string_functions.cpp Outdated Show resolved Hide resolved
be/src/exprs/string_functions.cpp Outdated Show resolved Hide resolved
kangkaisen
kangkaisen previously approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

kangpinghuang
kangpinghuang requested changes May 21, 2020
View reviewed changes
be/src/exprs/string_functions.cpp Show resolved Hide resolved
be/src/exprs/string_functions.cpp Outdated Show resolved Hide resolved
be/src/exprs/string_functions.cpp Outdated Show resolved Hide resolved
@yangzhg yangzhg requested a review from kangpinghuang May 22, 2020 01:58
kangpinghuang
kangpinghuang approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@kangpinghuang kangpinghuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman changed the title Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad Support utf-8 encoding in instr, locate, locate_pos, lpad, rpad May 22, 2020
@morningman morningman merged commit ba7d2db into apache:master May 22, 2020
@yangzhg yangzhg deleted the fix_utf8 branch July 3, 2020 06:35
@EmmyMiao87 EmmyMiao87 mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangpinghuang kangpinghuang kangpinghuang approved these changes

@kangkaisen kangkaisen kangkaisen left review comments

Assignees
No one assigned
Labels
area/sql/function Issues or PRs related to the SQL functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangzhg @morningman @kangkaisen @kangpinghuang