Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Rowset to SegmentGroup #364

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Rename Rowset to SegmentGroup #364

merged 2 commits into from
Nov 29, 2018

Conversation

kangpinghuang
Copy link
Contributor

Rename 'Rowset' to 'SegmentGroup' for be storage refactoring.
Including:

  1. Modify class Rowset to class SegmetGroup and modify related use cases;
  2. Modify related protobuf definitions;
  3. Modify inappropriate variable name 'index' to segment_group

Related ISSUE #351

@kangpinghuang kangpinghuang changed the title Rename rowset Rename Rowset to SegmentGroup Nov 28, 2018
@imay imay merged commit 85d0996 into apache:master Nov 29, 2018
@lide-reed lide-reed mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangpinghuang @imay