[improvement](cloud) Accelerate creating table by batching RPC In cloud #36786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
374
to
375
| return; | ||
| } |
There was a problem hiding this comment.
warning: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow]
Suggested change
| return; | |
| } | |
| } |
|
run buildall |
TPC-H: Total hot run time: 40946 ms |
TPC-DS: Total hot run time: 173651 ms |
ClickBench: Total hot run time: 30.3 s |
|
run buildall |
1 similar comment
|
run buildall |
deardeng
requested review from
dataroaring,
CalvinKirs and
morningman
as code owners
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40170 ms |
TPC-DS: Total hot run time: 173240 ms |
ClickBench: Total hot run time: 30.33 s |
gavinchou
reviewed
Jul 2, 2024
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
Outdated
Show resolved
Hide resolved
w41ter
reviewed
Jul 3, 2024
gavinchou
reviewed
Jul 5, 2024
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Jul 5, 2024
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
Show resolved
Hide resolved
gavinchou
reviewed
Jul 5, 2024
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java
Outdated
Show resolved
Hide resolved
gavinchou
reviewed
Jul 5, 2024
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
Outdated
Show resolved
Hide resolved
gavinchou
requested changes
Jul 5, 2024
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java
Outdated
Show resolved
Hide resolved
w41ter
previously approved these changes
Jul 10, 2024
gavinchou
previously approved these changes
Jul 13, 2024
|
run buildall |
gavinchou
approved these changes
Jul 13, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40417 ms |
TPC-DS: Total hot run time: 172109 ms |
ClickBench: Total hot run time: 30.86 s |
Yukang-Lian
approved these changes
Jul 14, 2024
ByteYue
approved these changes
Jul 14, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…ud (apache#36786) Create dynamic partitions, optimize from calling prepare rpc and commit rpc multiple times to only calling prepare and commit once ``` in one server(fe/ms) before optimize： Query OK, 0 rows affected (16.96 sec) Query OK, 0 rows affected (16.65 sec) Query OK, 0 rows affected (16.26 sec) Query OK, 0 rows affected (16.39 sec) Query OK, 0 rows affected (17.15 sec) after optimize： Query OK, 0 rows affected (13.31 sec) Query OK, 0 rows affected (11.71 sec) Query OK, 0 rows affected (11.81 sec) Query OK, 0 rows affected (11.55 sec) Query OK, 0 rows affected (12.07 sec) CREATE TABLE income_statistics_service ( statistics_date date , lyy_distributor_id bigint , lyy_equipment_group_id bigint , lyy_equipment_id bigint , service_type_id bigint , equipment_value varchar(40), wechat_pay_amount decimal, wechat_refund_amount decimal, alipay_pay_amount decimal, alipay_refund_amount decimal, union_pay_amount decimal, union_refund_amount decimal, app_pay_amount decimal, app_refund_amount decimal, ad_amount decimal, ad_distributor_count bigint, offline_coins bigint, online_coins bigint, online_startup_count bigint, gift_consumption_amount decimal, gift_consumption_count bigint, wechat_pay_coins bigint, alipay_pay_coins bigint, online_red_coins bigint, game_online_amount decimal, game_gift_consumption_amount decimal, game_gift_consumption_count bigint, rd_gift_consumption_count bigint, rd_gift_consumption_amount decimal, online_amount decimal, offline_amount decimal, offline_count bigint, wechat_pay_count bigint, alipay_pay_count bigint, union_pay_count bigint, wechat_refund_count bigint, alipay_refund_count bigint, union_refund_count bigint, app_pay_count bigint, app_refund_count bigint, created datetime, updated datetime, service_type_value varchar(32), service_type_name varchar(32), jd_pay_amount decimal , jd_refund_amount decimal , jd_pay_count bigint , jd_refund_count bigint , lyy_factory_id bigint, purse_amount decimal , purse_refund_amount decimal , purse_count bigint , purse_refund_count bigint , boost_pay_amount decimal , boost_refund_amount decimal , boost_pay_count bigint , boost_refund_count bigint , grabpay_pay_amount decimal , grabpay_refund_amount decimal , grabpay_pay_count bigint , grabpay_refund_count bigint , maybank_pay_amount decimal , maybank_refund_amount decimal , maybank_pay_count bigint , maybank_refund_count bigint , pay_start_amount decimal , exchange_amount decimal , auto_refund_count bigint , auto_refund_amount decimal , manual_refund_count bigint , manual_refund_amount decimal , custom_service_fee decimal, value_added_service_fee decimal, INDEX idx_statistics_date (`statistics_date`) USING BITMAP COMMENT '', INDEX idx_lyy_distributor_id (`lyy_distributor_id`) USING BITMAP COMMENT '', INDEX idx_lyy_equipment_group_id (`lyy_equipment_group_id`) USING BITMAP COMMENT '', INDEX idx_lyy_equipment_id (`lyy_equipment_id`) USING BITMAP COMMENT '', INDEX idx_service_type_id (`service_type_id`) USING BITMAP COMMENT '' ) ENGINE = OLAP UNIQUE KEY( `statistics_date`, `lyy_distributor_id`, `lyy_equipment_group_id`, `lyy_equipment_id`, `service_type_id` ) COMMENT 'OLAP' PARTITION BY RANGE(`statistics_date`)() DISTRIBUTED BY HASH(`lyy_distributor_id`) BUCKETS 6 PROPERTIES ( "file_cache_ttl_seconds" = "0", "bloom_filter_columns" = "statistics_date, lyy_distributor_id, lyy_equipment_group_id, lyy_equipment_id, service_type_id", "dynamic_partition.enable" = "true", "dynamic_partition.time_unit" = "DAY", "dynamic_partition.time_zone" = "Asia/Shanghai", "dynamic_partition.start" = "-730", "dynamic_partition.end" = "3", "dynamic_partition.prefix" = "p", "dynamic_partition.buckets" = "2", "dynamic_partition.create_history_partition" = "true", "dynamic_partition.history_partition_num" = "-1", "dynamic_partition.hot_partition_num" = "0", "dynamic_partition.reserved_history_periods" = "NULL", "enable_unique_key_merge_on_write" = "true", "light_schema_change" = "true" ); show partitions from income_statistics_service; ...... 734 rows in set (1.06 sec) ``` --------- Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…ud (#36786) Create dynamic partitions, optimize from calling prepare rpc and commit rpc multiple times to only calling prepare and commit once ``` in one server(fe/ms) before optimize： Query OK, 0 rows affected (16.96 sec) Query OK, 0 rows affected (16.65 sec) Query OK, 0 rows affected (16.26 sec) Query OK, 0 rows affected (16.39 sec) Query OK, 0 rows affected (17.15 sec) after optimize： Query OK, 0 rows affected (13.31 sec) Query OK, 0 rows affected (11.71 sec) Query OK, 0 rows affected (11.81 sec) Query OK, 0 rows affected (11.55 sec) Query OK, 0 rows affected (12.07 sec) CREATE TABLE income_statistics_service ( statistics_date date , lyy_distributor_id bigint , lyy_equipment_group_id bigint , lyy_equipment_id bigint , service_type_id bigint , equipment_value varchar(40), wechat_pay_amount decimal, wechat_refund_amount decimal, alipay_pay_amount decimal, alipay_refund_amount decimal, union_pay_amount decimal, union_refund_amount decimal, app_pay_amount decimal, app_refund_amount decimal, ad_amount decimal, ad_distributor_count bigint, offline_coins bigint, online_coins bigint, online_startup_count bigint, gift_consumption_amount decimal, gift_consumption_count bigint, wechat_pay_coins bigint, alipay_pay_coins bigint, online_red_coins bigint, game_online_amount decimal, game_gift_consumption_amount decimal, game_gift_consumption_count bigint, rd_gift_consumption_count bigint, rd_gift_consumption_amount decimal, online_amount decimal, offline_amount decimal, offline_count bigint, wechat_pay_count bigint, alipay_pay_count bigint, union_pay_count bigint, wechat_refund_count bigint, alipay_refund_count bigint, union_refund_count bigint, app_pay_count bigint, app_refund_count bigint, created datetime, updated datetime, service_type_value varchar(32), service_type_name varchar(32), jd_pay_amount decimal , jd_refund_amount decimal , jd_pay_count bigint , jd_refund_count bigint , lyy_factory_id bigint, purse_amount decimal , purse_refund_amount decimal , purse_count bigint , purse_refund_count bigint , boost_pay_amount decimal , boost_refund_amount decimal , boost_pay_count bigint , boost_refund_count bigint , grabpay_pay_amount decimal , grabpay_refund_amount decimal , grabpay_pay_count bigint , grabpay_refund_count bigint , maybank_pay_amount decimal , maybank_refund_amount decimal , maybank_pay_count bigint , maybank_refund_count bigint , pay_start_amount decimal , exchange_amount decimal , auto_refund_count bigint , auto_refund_amount decimal , manual_refund_count bigint , manual_refund_amount decimal , custom_service_fee decimal, value_added_service_fee decimal, INDEX idx_statistics_date (`statistics_date`) USING BITMAP COMMENT '', INDEX idx_lyy_distributor_id (`lyy_distributor_id`) USING BITMAP COMMENT '', INDEX idx_lyy_equipment_group_id (`lyy_equipment_group_id`) USING BITMAP COMMENT '', INDEX idx_lyy_equipment_id (`lyy_equipment_id`) USING BITMAP COMMENT '', INDEX idx_service_type_id (`service_type_id`) USING BITMAP COMMENT '' ) ENGINE = OLAP UNIQUE KEY( `statistics_date`, `lyy_distributor_id`, `lyy_equipment_group_id`, `lyy_equipment_id`, `service_type_id` ) COMMENT 'OLAP' PARTITION BY RANGE(`statistics_date`)() DISTRIBUTED BY HASH(`lyy_distributor_id`) BUCKETS 6 PROPERTIES ( "file_cache_ttl_seconds" = "0", "bloom_filter_columns" = "statistics_date, lyy_distributor_id, lyy_equipment_group_id, lyy_equipment_id, service_type_id", "dynamic_partition.enable" = "true", "dynamic_partition.time_unit" = "DAY", "dynamic_partition.time_zone" = "Asia/Shanghai", "dynamic_partition.start" = "-730", "dynamic_partition.end" = "3", "dynamic_partition.prefix" = "p", "dynamic_partition.buckets" = "2", "dynamic_partition.create_history_partition" = "true", "dynamic_partition.history_partition_num" = "-1", "dynamic_partition.hot_partition_num" = "0", "dynamic_partition.reserved_history_periods" = "NULL", "enable_unique_key_merge_on_write" = "true", "light_schema_change" = "true" ); show partitions from income_statistics_service; ...... 734 rows in set (1.06 sec) ``` --------- Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dynamic partitions, optimize from calling prepare rpc and commit
rpc multiple times to only calling prepare and commit once