[opt](function) opt ParseUrl function by process the input const column #36882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40177 ms |
TPC-DS: Total hot run time: 174821 ms |
ClickBench: Total hot run time: 30.37 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39846 ms |
TPC-DS: Total hot run time: 174178 ms |
ClickBench: Total hot run time: 30.36 s |
HappenLee
reviewed
Jun 27, 2024
| @@ -2277,70 +2279,102 @@ class FunctionStringParseUrl : public IFunction { | |||
| res_offsets.resize(input_rows_count); | |||
|
|
|||
| size_t argument_size = arguments.size(); | |||
| bool has_key = argument_size >= 3; | |||
| const bool has_key = argument_size >= 3; | |||
There was a problem hiding this comment.
max size seems 3，should be dcheck bigger than 3？
HappenLee
reviewed
Jun 27, 2024
| ColumnString::Chars& res_chars, | ||
| ColumnString::Offsets& res_offsets) { | ||
| for (size_t i = 0; i < size; ++i) { | ||
| UrlParser::UrlPart& url_part = url_parts[part_const ? 0 : i]; |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
TPC-H: Total hot run time: 40347 ms |
TPC-DS: Total hot run time: 173596 ms |
ClickBench: Total hot run time: 30.7 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40054 ms |
TPC-DS: Total hot run time: 174107 ms |
ClickBench: Total hot run time: 30.23 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Jul 1, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…mn (#36882) before ``` mysql [test10]>select count(parse_url(url, 'HOST')) from urldb; +-------------------------------+ | count(parse_url(url, 'HOST')) | +-------------------------------+ | 10000000 | +-------------------------------+ 1 row in set (1.12 sec) ``` now ``` mysql [test10]>select count(parse_url(url, 'HOST')) from urldb; +-------------------------------+ | count(parse_url(url, 'HOST')) | +-------------------------------+ | 10000000 | +-------------------------------+ 1 row in set (0.82 sec) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
before
now