[feature](json)support explode_json_object func #36887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| StringRef text = _json_object_column->get_data_at(row_idx); | ||
| if (text.data != nullptr) { | ||
| JsonbDocument* doc = JsonbDocument::createDocument(text.data, text.size); | ||
| if (UNLIKELY(!doc || !doc->getValue())) { |
There was a problem hiding this comment.
warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
if (UNLIKELY(!doc || !doc->getValue())) {
^Additional context
be/src/common/compiler_util.h:35: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^| auto writer = std::make_unique<JsonbWriter>(); | ||
| if (value->isObject()) { | ||
| _cur_size = value->length(); | ||
| ObjectVal* obj = (ObjectVal*)value; |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| ObjectVal* obj = (ObjectVal*)value; | |
| auto* obj = (ObjectVal*)value; |
|
|
||
| #pragma once | ||
|
|
||
| #include <stddef.h> |
There was a problem hiding this comment.
warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers]
Suggested change
| #include <stddef.h> | |
| #include <cstddef> |
|
run buildall |
TPC-H: Total hot run time: 40081 ms |
TPC-DS: Total hot run time: 175070 ms |
ClickBench: Total hot run time: 30.89 s |
morrySnow
reviewed
Jun 27, 2024
...n/java/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonObject.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonObject.java
Outdated
Show resolved
Hide resolved
...a/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonObjectOuter.java
Show resolved
Hide resolved
|
run buildall |
morrySnow
reviewed
Jun 27, 2024
...a/org/apache/doris/nereids/trees/expressions/functions/generator/ExplodeJsonObjectOuter.java
Outdated
Show resolved
Hide resolved
TPC-H: Total hot run time: 39946 ms |
|
run buildall |
TPC-H: Total hot run time: 40324 ms |
TPC-DS: Total hot run time: 169919 ms |
ClickBench: Total hot run time: 30.24 s |
morrySnow
previously approved these changes
Jun 27, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
eldenmoon
reviewed
Jun 27, 2024
eldenmoon
reviewed
Jun 27, 2024
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 40614 ms |
TPC-DS: Total hot run time: 174471 ms |
ClickBench: Total hot run time: 30.76 s |
morrySnow
previously approved these changes
Jul 1, 2024
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 40066 ms |
TPC-DS: Total hot run time: 173411 ms |
ClickBench: Total hot run time: 30.4 s |
morrySnow
approved these changes
Jul 2, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
This was referenced Jul 2, 2024
xiaokang
pushed a commit
that referenced
this pull request
Jul 16, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
after this pr we support expand json object into two column with key column (string) ,and value column(json value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
after this pr we support
expand json object into two column with key column (string) ,and value column(json value)
Issue Number: close #xxx