Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](group commit) Fix group commit in nereids #37002

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[fix](group commit) Fix group commit in nereids #37002

merged 1 commit into from
Jul 4, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jun 28, 2024

Proposed changes

Before: the insert into values in group commit use the stream load way to load data, this may cause complex data type load error.
After: use the original insert into values way(scanner node is union node), sink is group_commit_block_sink.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jun 28, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jun 28, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40274 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 05e8c24e2e775c3ca1cf1c1af213d6e5852a43ec, data reload: false

------ Round 1 ----------------------------------
q1	18356	4725	4369	4369
q2	2642	198	190	190
q3	11308	1186	1166	1166
q4	11145	831	909	831
q5	7523	2743	2700	2700
q6	219	137	143	137
q7	979	602	617	602
q8	9515	2121	2117	2117
q9	9300	6525	6518	6518
q10	8910	3728	3722	3722
q11	440	240	239	239
q12	402	240	224	224
q13	17786	2961	3030	2961
q14	262	226	211	211
q15	514	478	480	478
q16	505	374	368	368
q17	989	619	636	619
q18	8104	7324	7455	7324
q19	5332	1591	1498	1498
q20	670	324	329	324
q21	4993	3340	3875	3340
q22	400	336	346	336
Total cold run time: 120294 ms
Total hot run time: 40274 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4444	4264	4207	4207
q2	376	264	267	264
q3	2954	2693	2735	2693
q4	1912	1585	1639	1585
q5	5271	5295	5313	5295
q6	218	129	129	129
q7	2140	1750	1746	1746
q8	3209	3365	3361	3361
q9	8346	8400	8378	8378
q10	3848	3703	3736	3703
q11	578	494	504	494
q12	786	607	595	595
q13	16400	2999	2990	2990
q14	297	257	259	257
q15	533	486	472	472
q16	457	418	446	418
q17	1787	1499	1478	1478
q18	7543	7440	7380	7380
q19	1772	1584	1549	1549
q20	2020	1778	1777	1777
q21	4845	4743	4835	4743
q22	633	551	552	551
Total cold run time: 70369 ms
Total hot run time: 54065 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169385 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 05e8c24e2e775c3ca1cf1c1af213d6e5852a43ec, data reload: false

query1	919	384	376	376
query2	6486	2473	2301	2301
query3	6644	209	216	209
query4	19339	17463	17195	17195
query5	4151	491	475	475
query6	273	181	172	172
query7	4605	306	283	283
query8	301	294	304	294
query9	8701	2490	2468	2468
query10	613	307	295	295
query11	10551	9975	10084	9975
query12	131	89	82	82
query13	1636	375	375	375
query14	9753	6973	7640	6973
query15	218	178	190	178
query16	7910	266	259	259
query17	1910	538	519	519
query18	1977	272	265	265
query19	208	145	151	145
query20	85	81	78	78
query21	212	139	128	128
query22	4482	4028	3983	3983
query23	33644	32899	32822	32822
query24	11183	2830	2776	2776
query25	640	359	357	357
query26	1370	144	148	144
query27	2974	312	318	312
query28	7386	2122	2111	2111
query29	909	633	609	609
query30	283	160	153	153
query31	935	729	741	729
query32	92	49	52	49
query33	767	280	305	280
query34	922	475	465	465
query35	739	617	622	617
query36	1088	920	924	920
query37	153	71	68	68
query38	2850	2768	2763	2763
query39	875	783	799	783
query40	202	123	124	123
query41	52	49	48	48
query42	114	100	98	98
query43	620	555	541	541
query44	1246	743	748	743
query45	189	165	166	165
query46	1072	746	706	706
query47	1874	1805	1749	1749
query48	361	295	307	295
query49	1070	404	397	397
query50	763	377	389	377
query51	6836	6911	6679	6679
query52	103	101	91	91
query53	360	284	298	284
query54	899	449	438	438
query55	74	76	75	75
query56	306	263	274	263
query57	1159	1052	1070	1052
query58	253	238	235	235
query59	3486	3315	3209	3209
query60	306	271	271	271
query61	96	91	94	91
query62	660	452	454	452
query63	323	289	294	289
query64	8936	2265	1737	1737
query65	3139	3056	3115	3056
query66	1015	341	327	327
query67	15371	15294	14835	14835
query68	4528	545	542	542
query69	467	297	300	297
query70	1214	1053	1141	1053
query71	394	273	271	271
query72	7054	5546	2781	2781
query73	739	324	321	321
query74	6082	5475	5464	5464
query75	3457	2646	2658	2646
query76	2772	910	940	910
query77	445	303	298	298
query78	10482	9754	9630	9630
query79	2702	516	527	516
query80	1187	468	459	459
query81	599	219	277	219
query82	774	101	102	101
query83	242	168	166	166
query84	240	88	87	87
query85	1670	280	275	275
query86	509	334	327	327
query87	3261	3074	3045	3045
query88	4118	2347	2353	2347
query89	461	391	368	368
query90	1777	190	192	190
query91	126	97	100	97
query92	60	49	48	48
query93	1854	513	521	513
query94	1251	195	186	186
query95	402	308	307	307
query96	592	276	264	264
query97	3238	3017	3088	3017
query98	213	197	190	190
query99	1206	838	861	838
Total cold run time: 272916 ms
Total hot run time: 169385 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 05e8c24e2e775c3ca1cf1c1af213d6e5852a43ec, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.07	0.07
query5	0.50	0.49	0.50
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.51	0.49
query10	0.55	0.55	0.52
query11	0.16	0.11	0.11
query12	0.16	0.12	0.13
query13	0.59	0.58	0.58
query14	0.77	0.78	0.79
query15	0.84	0.83	0.81
query16	0.37	0.38	0.38
query17	0.99	0.98	0.97
query18	0.22	0.25	0.24
query19	1.77	1.67	1.65
query20	0.01	0.01	0.01
query21	15.44	0.74	0.65
query22	4.34	6.77	2.06
query23	18.32	1.40	1.26
query24	2.08	0.23	0.21
query25	0.16	0.08	0.09
query26	0.26	0.18	0.18
query27	0.08	0.08	0.07
query28	13.29	1.00	1.01
query29	12.63	3.22	3.24
query30	0.25	0.07	0.05
query31	2.87	0.40	0.38
query32	3.27	0.48	0.47
query33	2.88	2.91	2.85
query34	17.26	4.40	4.39
query35	4.48	4.44	4.47
query36	0.65	0.46	0.48
query37	0.18	0.16	0.15
query38	0.16	0.14	0.15
query39	0.05	0.03	0.04
query40	0.19	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.76 s
Total hot run time: 30.48 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 2, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39996 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

------ Round 1 ----------------------------------
q1	18330	4689	4310	4310
q2	2021	195	186	186
q3	10543	1142	1074	1074
q4	10231	816	897	816
q5	7522	2713	2653	2653
q6	219	139	141	139
q7	953	603	583	583
q8	9231	2104	2106	2104
q9	8892	6507	6522	6507
q10	8900	3758	3739	3739
q11	445	231	238	231
q12	417	243	245	243
q13	17763	2950	2980	2950
q14	260	223	225	223
q15	515	477	477	477
q16	523	387	381	381
q17	996	622	772	622
q18	8128	7424	7568	7424
q19	5910	1421	1509	1421
q20	659	318	323	318
q21	4941	3256	3309	3256
q22	398	339	339	339
Total cold run time: 117797 ms
Total hot run time: 39996 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4517	4318	4255	4255
q2	368	270	264	264
q3	3042	2925	2933	2925
q4	2015	1717	1727	1717
q5	5619	5501	5499	5499
q6	229	141	135	135
q7	2223	1879	1852	1852
q8	3287	3476	3435	3435
q9	8732	8801	8817	8801
q10	4221	3756	3769	3756
q11	628	516	515	515
q12	811	657	641	641
q13	17183	3213	3225	3213
q14	294	286	260	260
q15	537	482	487	482
q16	510	429	425	425
q17	1838	1524	1505	1505
q18	8034	7996	7768	7768
q19	1843	1600	1601	1600
q20	2130	1867	1848	1848
q21	7678	4911	4827	4827
q22	655	560	540	540
Total cold run time: 76394 ms
Total hot run time: 56263 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173676 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

query1	922	376	373	373
query2	6464	2508	2442	2442
query3	6638	210	214	210
query4	19525	17427	17311	17311
query5	3730	496	478	478
query6	274	171	183	171
query7	4599	309	289	289
query8	311	290	285	285
query9	8471	2367	2364	2364
query10	576	311	288	288
query11	10601	10025	9970	9970
query12	117	90	83	83
query13	1643	371	376	371
query14	9388	7058	7508	7058
query15	233	180	193	180
query16	7679	266	266	266
query17	1428	563	513	513
query18	1946	276	267	267
query19	191	147	149	147
query20	90	80	80	80
query21	201	125	124	124
query22	4334	4152	4035	4035
query23	33842	33926	33717	33717
query24	10508	2848	2839	2839
query25	600	379	403	379
query26	707	155	151	151
query27	2328	331	321	321
query28	5923	2128	2145	2128
query29	898	649	625	625
query30	245	159	160	159
query31	960	784	744	744
query32	99	56	54	54
query33	672	292	298	292
query34	891	491	478	478
query35	758	671	622	622
query36	1118	971	995	971
query37	138	85	81	81
query38	2957	2815	2922	2815
query39	900	848	842	842
query40	215	130	126	126
query41	57	51	52	51
query42	112	104	104	104
query43	629	568	531	531
query44	1114	745	726	726
query45	189	160	161	160
query46	1072	690	721	690
query47	1845	1764	1747	1747
query48	383	295	294	294
query49	829	409	416	409
query50	784	382	384	382
query51	6934	6786	6724	6724
query52	101	91	101	91
query53	364	293	288	288
query54	899	440	445	440
query55	76	73	74	73
query56	294	270	271	270
query57	1122	1054	1021	1021
query58	287	246	269	246
query59	3420	3455	3080	3080
query60	298	279	281	279
query61	96	89	92	89
query62	592	440	439	439
query63	321	284	292	284
query64	8436	2240	1821	1821
query65	3182	3085	3099	3085
query66	755	331	318	318
query67	15425	14990	15132	14990
query68	4504	541	549	541
query69	568	406	321	321
query70	1184	1034	1150	1034
query71	400	281	278	278
query72	7076	5796	5119	5119
query73	748	323	324	323
query74	5791	5495	5436	5436
query75	3383	2670	2682	2670
query76	2335	941	1038	941
query77	619	306	311	306
query78	10323	9879	9795	9795
query79	1830	520	523	520
query80	1306	491	478	478
query81	612	217	227	217
query82	1049	108	104	104
query83	287	170	168	168
query84	248	85	84	84
query85	1040	275	331	275
query86	405	343	347	343
query87	3247	3099	3056	3056
query88	3233	2373	2346	2346
query89	466	379	383	379
query90	1661	191	190	190
query91	129	103	101	101
query92	65	51	48	48
query93	1757	516	508	508
query94	1100	193	192	192
query95	409	316	319	316
query96	589	268	269	268
query97	3192	3023	3019	3019
query98	220	207	192	192
query99	1119	827	866	827
Total cold run time: 263631 ms
Total hot run time: 173676 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.23	0.06	0.05
query4	1.66	0.08	0.08
query5	0.50	0.47	0.50
query6	1.13	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.48	0.48
query10	0.54	0.55	0.55
query11	0.14	0.10	0.12
query12	0.16	0.12	0.12
query13	0.59	0.58	0.58
query14	0.76	0.76	0.79
query15	0.85	0.81	0.81
query16	0.36	0.35	0.36
query17	0.97	1.01	1.00
query18	0.22	0.25	0.25
query19	1.80	1.77	1.74
query20	0.02	0.01	0.01
query21	15.44	0.76	0.66
query22	4.05	7.14	2.23
query23	18.32	1.43	1.26
query24	2.17	0.22	0.22
query25	0.15	0.09	0.08
query26	0.28	0.17	0.17
query27	0.08	0.08	0.07
query28	13.24	1.01	1.00
query29	12.58	3.26	3.29
query30	0.25	0.06	0.06
query31	2.86	0.40	0.38
query32	3.28	0.48	0.46
query33	2.86	2.88	2.90
query34	17.16	4.40	4.37
query35	4.46	4.47	4.53
query36	0.65	0.45	0.51
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.03
query40	0.19	0.14	0.14
query41	0.10	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.29 s
Total hot run time: 30.79 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 3, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39832 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

------ Round 1 ----------------------------------
q1	17743	4470	4327	4327
q2	2023	189	186	186
q3	10553	1157	1073	1073
q4	10215	760	828	760
q5	7510	2681	2557	2557
q6	226	138	139	138
q7	966	601	605	601
q8	9226	2079	2120	2079
q9	9073	6520	6510	6510
q10	8884	3735	3754	3735
q11	459	234	236	234
q12	433	240	239	239
q13	18858	3005	2972	2972
q14	265	225	230	225
q15	521	487	482	482
q16	525	388	374	374
q17	976	649	708	649
q18	8148	7480	7425	7425
q19	4694	1570	1356	1356
q20	655	323	336	323
q21	4963	3258	3254	3254
q22	395	335	333	333
Total cold run time: 117311 ms
Total hot run time: 39832 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4490	4275	4242	4242
q2	379	278	254	254
q3	2978	2847	2842	2842
q4	1996	1691	1708	1691
q5	5693	5612	5537	5537
q6	231	144	135	135
q7	2213	1841	1841	1841
q8	3284	3454	3407	3407
q9	8792	8783	8890	8783
q10	4134	3963	3686	3686
q11	623	507	497	497
q12	834	643	666	643
q13	16057	3169	3165	3165
q14	316	285	304	285
q15	559	478	472	472
q16	495	447	447	447
q17	1809	1550	1518	1518
q18	8159	7976	7968	7968
q19	1772	1707	1644	1644
q20	2133	1901	1846	1846
q21	9634	5080	4770	4770
q22	613	536	554	536
Total cold run time: 77194 ms
Total hot run time: 56209 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173255 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

query1	912	382	381	381
query2	6490	2350	2229	2229
query3	6637	213	215	213
query4	19021	17329	17183	17183
query5	3676	486	470	470
query6	268	184	173	173
query7	4588	305	297	297
query8	304	294	282	282
query9	8555	2382	2361	2361
query10	572	315	287	287
query11	10480	10085	10014	10014
query12	115	90	81	81
query13	1639	377	361	361
query14	9485	7580	7797	7580
query15	216	184	184	184
query16	7698	306	306	306
query17	1813	555	518	518
query18	1766	269	265	265
query19	203	153	150	150
query20	93	83	80	80
query21	206	131	130	130
query22	4296	3936	3936	3936
query23	33735	33761	33513	33513
query24	10978	2909	2904	2904
query25	590	400	391	391
query26	712	160	155	155
query27	2297	330	339	330
query28	6152	2116	2110	2110
query29	876	670	637	637
query30	258	156	155	155
query31	977	769	752	752
query32	95	52	53	52
query33	733	294	313	294
query34	924	482	504	482
query35	754	650	675	650
query36	1153	977	962	962
query37	139	81	82	81
query38	2941	2864	2811	2811
query39	846	806	805	805
query40	198	128	129	128
query41	56	48	46	46
query42	121	107	102	102
query43	592	539	546	539
query44	1179	719	739	719
query45	193	164	166	164
query46	1099	711	711	711
query47	1891	1763	1742	1742
query48	367	290	288	288
query49	848	413	411	411
query50	772	379	383	379
query51	6940	6845	6820	6820
query52	97	90	90	90
query53	358	293	285	285
query54	919	444	442	442
query55	78	75	74	74
query56	278	270	263	263
query57	1132	1026	1061	1026
query58	256	233	247	233
query59	3209	3146	3216	3146
query60	296	278	289	278
query61	93	95	92	92
query62	589	454	438	438
query63	321	283	285	283
query64	8534	2271	1765	1765
query65	3177	3116	3106	3106
query66	746	326	331	326
query67	15159	14983	14938	14938
query68	4497	535	540	535
query69	543	390	322	322
query70	1193	1049	1090	1049
query71	423	280	275	275
query72	7139	5735	5545	5545
query73	738	323	322	322
query74	5983	5494	5451	5451
query75	3496	2630	2676	2630
query76	2795	964	891	891
query77	451	293	292	292
query78	9720	8945	8976	8945
query79	2293	519	518	518
query80	1205	468	464	464
query81	590	217	222	217
query82	827	101	108	101
query83	238	168	171	168
query84	242	85	89	85
query85	1819	288	279	279
query86	494	324	305	305
query87	3346	3065	3064	3064
query88	3994	2345	2345	2345
query89	502	390	377	377
query90	1789	185	189	185
query91	129	97	105	97
query92	62	49	53	49
query93	2505	502	514	502
query94	1110	209	209	209
query95	406	309	314	309
query96	593	263	264	263
query97	3204	3012	3008	3008
query98	224	197	198	197
query99	1202	857	900	857
Total cold run time: 266443 ms
Total hot run time: 173255 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.09 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 70e0eaead1eaceb4e9d78dc2d3c775fc4b1c79d0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.51	0.51	0.50
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.53	0.53	0.54
query11	0.15	0.11	0.12
query12	0.15	0.12	0.13
query13	0.60	0.58	0.58
query14	0.76	0.78	0.78
query15	0.84	0.80	0.82
query16	0.37	0.35	0.37
query17	0.96	0.97	0.97
query18	0.22	0.26	0.23
query19	1.83	1.69	1.71
query20	0.01	0.01	0.01
query21	15.44	0.77	0.64
query22	4.29	7.04	2.38
query23	18.28	1.41	1.32
query24	2.05	0.23	0.22
query25	0.16	0.09	0.09
query26	0.27	0.18	0.17
query27	0.08	0.07	0.07
query28	13.31	1.04	0.99
query29	12.57	3.31	3.29
query30	0.24	0.06	0.06
query31	2.84	0.41	0.39
query32	3.26	0.49	0.47
query33	2.90	2.86	2.96
query34	17.15	4.49	4.45
query35	4.54	4.52	4.54
query36	0.64	0.49	0.47
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.18	0.14	0.14
query41	0.09	0.04	0.05
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.47 s
Total hot run time: 31.09 s

dataroaring
dataroaring approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit ac21d76 into apache:master Jul 4, 2024
25 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@mymeiyi @dataroaring
[fix](group commit) Fix group commit in nereids (#37002)
9b0a16f 
## Proposed changes

Before: the insert into values in group commit use the stream load way
to load data, this may cause complex data type load error.
After: use the original insert into values way(scanner node is union
node), sink is group_commit_block_sink.
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged meta-change reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mymeiyi @doris-robot @Yukang-Lian @dataroaring