Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor](timezone) refactor tzdata load to accelerate and unify timezone parsing #37062

Merged
merged 7 commits into from
Jul 4, 2024
Merged

[Refactor](timezone) refactor tzdata load to accelerate and unify timezone parsing #37062

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d6e181
Revert "[chore](be) Add default timezone files (#25097)"
zclllyybb Jul 1, 2024
843fbd1
refactor
zclllyybb Jul 1, 2024
fc2da61
fix test
zclllyybb Jul 1, 2024
872c03c
support case insensitive parsing and bugfix in nereids
zclllyybb Jul 1, 2024
5bcf698
fix bug on different OS
zclllyybb Jul 2, 2024
015c158
fix cases with dup tz name
zclllyybb Jul 2, 2024
bbba73d
Merge branch 'master' into opt_timezone
zclllyybb Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ be/tags
be/test/olap/test_data/tablet_meta_test.hdr
be/.devcontainer/
be/src/apache-orc/
zoneinfo/

# Cloud
cloud/build*/
Expand Down
3 changes: 0 additions & 3 deletions be/src/common/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,9 +1168,6 @@ DEFINE_mBool(enable_workload_group_memory_gc, "true");

DEFINE_Bool(ignore_always_true_predicate_for_segment, "true");

// Dir of default timezone files
DEFINE_String(default_tzfiles_path, "${DORIS_HOME}/zoneinfo");

// Ingest binlog work pool size, -1 is disable, 0 is hardware concurrency
DEFINE_Int32(ingest_binlog_work_pool_size, "-1");

Expand Down
3 changes: 0 additions & 3 deletions be/src/common/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,9 +1250,6 @@ DECLARE_Bool(enable_flush_file_cache_async);
// Remove predicate that is always true for a segment.
DECLARE_Bool(ignore_always_true_predicate_for_segment);

// Dir of default timezone files
DECLARE_String(default_tzfiles_path);

// Ingest binlog work pool size
DECLARE_Int32(ingest_binlog_work_pool_size);

Expand Down
1 change: 0 additions & 1 deletion be/src/runtime/exec_env_init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ Status ExecEnv::_init(const std::vector<StorePath>& store_paths,
_frontend_client_cache = new FrontendServiceClientCache(config::max_client_cache_size_per_host);
_broker_client_cache = new BrokerServiceClientCache(config::max_client_cache_size_per_host);

TimezoneUtils::load_timezone_names();
TimezoneUtils::load_timezones_to_cache();

static_cast<void>(ThreadPoolBuilder("SendBatchThreadPool")
Expand Down
Loading
Loading