Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](hash join) fix numeric overflow when calculating hash table bucket size #37193 #37213

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[fix](hash join) fix numeric overflow when calculating hash table bucket size #37193 #37213

merged 1 commit into from
Jul 4, 2024

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Bp #37193

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/common/hash_table/join_hash_table.h
@@ -19,6 +19,8 @@

#include <gen_cpp/PlanNodes_types.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/PlanNodes_types.h>
         ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.33% (9151/25186)
Line Coverage: 27.87% (74676/267925)
Region Coverage: 26.77% (38515/143847)
Branch Coverage: 23.46% (19510/83160)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d624ded32658389c0e8361f122e8331afccdabe0_d624ded32658389c0e8361f122e8331afccdabe0/report/index.html

HappenLee
HappenLee approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit fb344b6 into apache:branch-2.1 Jul 4, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacktengg @doris-robot @HappenLee